Account may change when navigating between UIs#6151 #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shabeeb-aot
requested review from
karthik-aot,
saravanpa-aot,
sumesh-aot and
pwei1018
|
I added in some place, Let me know if i miss any links |
Codecov Report
@@ Coverage Diff @@
## main #1902 +/- ##
==========================================
- Coverage 79.31% 79.30% -0.01%
==========================================
Files 284 284
Lines 9822 9823 +1
Branches 490 491 +1
==========================================
Hits 7790 7790
- Misses 2032 2033 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sumesh-aot
approved these changes
Jan 28, 2022
| } else { | ||
| window.location.href = ConfigHelper.getNroUrl() | ||
| window.location.href = appendAccountId(ConfigHelper.getNroUrl()) |
There was a problem hiding this comment.
can we remove LD flag check ?
| } else { | ||
| window.location.href = `${ConfigHelper.getNroUrl()}nro.htm?_flowId=anonymous-monitor-flow&_flowExecutionKey=e1s1` | ||
| window.location.href = appendAccountId(`${ConfigHelper.getNroUrl()}nro.htm?_flowId=anonymous-monitor-flow&_flowExecutionKey=e1s1`) |
There was a problem hiding this comment.
this also can be removed
| } else { | ||
| window.location.href = ConfigHelper.getNroUrl() | ||
| window.location.href = appendAccountId(ConfigHelper.getNroUrl()) |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#6151
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).