Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6884 - Add get orgproducts permission for Staff View Account role #1900

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

karthik-aot
Copy link
Contributor

Issue #:
bcgov/entity#6884

Description of changes:

  • Accept Staff View Account role for get orgproducts endpoints

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@karthik-aot karthik-aot added the bug Something isn't working label Jan 28, 2022
@karthik-aot karthik-aot self-assigned this Jan 28, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #1900 (5fd7d8c) into main (a19d8ee) will increase coverage by 0.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1900      +/-   ##
==========================================
+ Coverage   79.31%   79.87%   +0.55%     
==========================================
  Files         284      277       -7     
  Lines        9822     9653     -169     
  Branches      490      449      -41     
==========================================
- Hits         7790     7710      -80     
+ Misses       2032     1943      -89     
Flag Coverage Δ
authapi 90.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/auth/create-account/UserProfileForm.vue 80.00% <ø> (+22.85%) ⬆️
auth-api/src/auth_api/resources/org_products.py 88.09% <100.00%> (ø)
status-api/src/status_api/resources/whatsnew.py 100.00% <100.00%> (ø)
...ponents/auth/create-account/AccountCreateBasic.vue 20.00% <0.00%> (-13.34%) ⬇️
...s/auth/account-settings/product/ProductPackage.vue 57.14% <0.00%> (-6.50%) ⬇️
...uth-web/src/views/auth/staff/ReviewAccountView.vue 58.33% <0.00%> (-6.38%) ⬇️
auth-web/src/store/modules/codes.ts 54.05% <0.00%> (-2.71%) ⬇️
auth-web/src/util/config-helper.ts 23.94% <0.00%> (-1.36%) ⬇️
auth-web/src/services/business.services.ts 7.14% <0.00%> (-0.55%) ⬇️
auth-web/src/util/common-util.ts 78.18% <0.00%> (-0.25%) ⬇️
... and 31 more

@karthik-aot karthik-aot merged commit c17d2a1 into bcgov:main Jan 28, 2022
@karthik-aot karthik-aot deleted the bug/6884 branch January 28, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants