Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added application security header. #1894

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

pwei1018
Copy link
Collaborator

Issue #:
bcgov/entity#10195

Description of changes:

  1. added application security header;
  2. exclude the http 2xx and 3xx logging from console;

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #1894 (a19d8ee) into main (900268c) will decrease coverage by 0.55%.
The diff coverage is 72.54%.

@@            Coverage Diff             @@
##             main    #1894      +/-   ##
==========================================
- Coverage   79.87%   79.31%   -0.56%     
==========================================
  Files         277      284       +7     
  Lines        9653     9822     +169     
  Branches      449      490      +41     
==========================================
+ Hits         7710     7790      +80     
- Misses       1943     2032      +89     
Flag Coverage Δ
authweb 44.19% <72.54%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onents/auth/manage-business/AddNameRequestForm.vue 50.00% <ø> (ø)
auth-web/src/services/business.services.ts 7.69% <0.00%> (+0.54%) ⬆️
auth-web/src/util/config-helper.ts 25.30% <0.00%> (+1.35%) ⬆️
auth-web/src/views/auth/SigninView.vue 100.00% <ø> (ø)
auth-web/src/store/modules/business.ts 18.18% <22.22%> (-2.00%) ⬇️
...nts/auth/manage-business/AffiliatedEntityTable.vue 11.11% <50.00%> (-1.39%) ⬇️
...ponents/auth/create-account/AccountCreateBasic.vue 33.33% <100.00%> (+13.33%) ⬆️
auth-web/src/util/constants.ts 100.00% <100.00%> (ø)
...auth/account-settings/account-info/AccountInfo.vue 54.54% <0.00%> (-28.79%) ⬇️
...components/auth/create-account/UserProfileForm.vue 57.14% <0.00%> (-22.86%) ⬇️
... and 34 more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@ozamani9
Copy link
Contributor

I compared the nginx file to the nginx file from Name Request. Looks great.

Copy link
Contributor

@ozamani9 ozamani9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Look good

@pwei1018 pwei1018 merged commit 33fd895 into bcgov:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants