10255 - Bug fix for Account accessType change premium to GovN #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1872 +/- ##
==========================================
- Coverage 79.70% 79.14% -0.56%
==========================================
Files 276 283 +7
Lines 9603 9731 +128
Branches 449 304 -145
==========================================
+ Hits 7654 7702 +48
- Misses 1949 2029 +80
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sumesh-aot
reviewed
Jan 7, 2022
| @@ -20,7 +20,7 @@ | |||
| <span data-test="txt-selected-access-type">{{ selectedAccessType === AccessType.GOVN ? 'Government agency (other than BC provincial)' : 'Regular Access'}}</span> | |||
| </div> | |||
| <div | |||
| v-if="canChangeAccessType" | |||
| v-if="canChangeAccessType && selectedAccessType !== AccessType.GOVN" | |||
There was a problem hiding this comment.
Is this condition to enable the Change button? If so, shouldn't this check for GOVM too ?
There was a problem hiding this comment.
Refactored the code accordingly
shabeeb-aot
approved these changes
Jan 7, 2022
| @@ -122,6 +122,25 @@ export default class AccountAccessType extends Vue { | |||
| return this.currentOrgPaymentType && this.currentOrgPaymentType === PaymentTypes.PAD | |||
| } | |||
|
|
|||
| public get isChangeButtonEnabled (): boolean { | |||
| let isChangeButtonEnabled: boolean = this.organization.orgType === Account.PREMIUM // Only Premium accounts can be edited | |||
There was a problem hiding this comment.
use different name for function and variables
|
Kudos, SonarCloud Quality Gate passed!
|
sumesh-aot
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#10255
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).