-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a Whatsnew endpoint. #1864
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1864 +/- ##
==========================================
+ Coverage 79.71% 79.75% +0.04%
==========================================
Files 276 277 +1
Lines 9605 9624 +19
Branches 449 449
==========================================
+ Hits 7657 7676 +19
Misses 1948 1948
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cce2582
to
9d2ea2f
Compare
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Few points, may be not needed for MVP;
- Do we need to support this at user level? So that it won't be shown as unread in the menu bar if the user has already clicked on it.
- Any plans to store if user has read, so that whoever hasn't logged in for a while would get a long list; whereas recently logged in and read users would get only what they didn't see yet.
There is no detail requirement now. I put it here temporary. We might merge this status api and notify api together and create some table to store the state if need. Also, need to create a UI to let change management team or others to maintain the news content. |
Issue #:
bcgov/entity#9811
Description of changes:
Add a whatsnew endpoint to pull news from configuration.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).