Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Whatsnew endpoint. #1864

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Added a Whatsnew endpoint. #1864

merged 1 commit into from
Jan 12, 2022

Conversation

pwei1018
Copy link
Collaborator

Issue #:
bcgov/entity#9811

Description of changes:
Add a whatsnew endpoint to pull news from configuration.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #1864 (9d2ea2f) into main (fffc33c) will increase coverage by 0.04%.
The diff coverage is 81.39%.

@@            Coverage Diff             @@
##             main    #1864      +/-   ##
==========================================
+ Coverage   79.71%   79.75%   +0.04%     
==========================================
  Files         276      277       +1     
  Lines        9605     9624      +19     
  Branches      449      449              
==========================================
+ Hits         7657     7676      +19     
  Misses       1948     1948              
Flag Coverage Δ
statusapi 97.48% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
auth-api/src/auth_api/services/affidavit.py 89.62% <ø> (ø)
auth-web/src/services/org.services.ts 3.63% <ø> (ø)
auth-web/src/services/user.services.ts 4.76% <0.00%> (ø)
auth-web/src/store/modules/staff.ts 32.89% <0.00%> (ø)
auth-api/src/auth_api/services/org.py 86.96% <57.14%> (ø)
auth-api/src/auth_api/services/task.py 83.87% <87.50%> (ø)
status-api/src/status_api/resources/__init__.py 100.00% <100.00%> (ø)
status-api/src/status_api/resources/whatsnew.py 100.00% <100.00%> (ø)
status-api/src/status_api/services/status.py 95.94% <100.00%> (ø)
status-api/src/status_api/utils/util_logging.py 100.00% <100.00%> (ø)
... and 4 more

@pwei1018 pwei1018 requested a review from shabeeb-aot December 16, 2021 22:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

Copy link
Contributor

@sumesh-aot sumesh-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Few points, may be not needed for MVP;

  • Do we need to support this at user level? So that it won't be shown as unread in the menu bar if the user has already clicked on it.
  • Any plans to store if user has read, so that whoever hasn't logged in for a while would get a long list; whereas recently logged in and read users would get only what they didn't see yet.

@pwei1018
Copy link
Collaborator Author

Looks good. Few points, may be not needed for MVP;

  • Do we need to support this at user level? So that it won't be shown as unread in the menu bar if the user has already clicked on it.
  • Any plans to store if user has read, so that whoever hasn't logged in for a while would get a long list; whereas recently logged in and read users would get only what they didn't see yet.

There is no detail requirement now. I put it here temporary. We might merge this status api and notify api together and create some table to store the state if need. Also, need to create a UI to let change management team or others to maintain the news content.

@pwei1018 pwei1018 merged commit 65c593b into bcgov:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants