Convert class components to options components for filter #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
esune
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Changes look good to me, I tried running a local instance and things work as expected.
there is, however, an import error that is thrown when starting the development server:
Error: The following dependencies are imported but could not be resolved:
vuetify/types/services/goto (imported by C:/Developer/git-repos/orgbook-bc-client/src/components/entity/EntityResult.vue?id=0)
Are they installed?
at file:///C:/Developer/git-repos/orgbook-bc-client/node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:50666:15
at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
at async file:///C:/Developer/git-repos/orgbook-bc-client/node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:50171:26
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step to converting the org book client to options components which are supported in vue 3 as part of #242