Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRC-1036: Update updateShapes cronjob config to run npm install first. #193

Merged
merged 1 commit into from
Feb 12, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions openshift/templates/jobs/updateShapes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,12 @@ spec:
command:
- bash
- -c
- 'node seed/shapesMigration/update.js "${API_USERNAME}" "${API_PASSWORD}" "${API_PROTOCOL}" "${API_HOST}" "${API_PORT}" "${CLIENT_ID}" "${GRANT_TYPE}" "${AUTH_ENDPOINT}" ; if [ "${PIPESTATUS[0]}" -ne "1" ]; then curl -X
POST -H "Content-type: application/json" --data "${JSON_PAYLOAD}" "${NOTIFICATION_URL}";else curl -X POST -H "Content-type: application/json" --data "${JSON_PAYLOAD_FAIL}"
"${NOTIFICATION_URL}" fi'
- 'npm install --prefix seed/;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this line was added. Everything else is just re-arranging for readability.

node seed/shapesMigration/update.js "${API_USERNAME}" "${API_PASSWORD}" "${API_PROTOCOL}" "${API_HOST}" "${API_PORT}" "${CLIENT_ID}" "${GRANT_TYPE}" "${AUTH_ENDPOINT}";
if [ "${PIPESTATUS[0]}" -ne "1" ];
then curl -X POST -H "Content-type: application/json" --data "${JSON_PAYLOAD}" "${NOTIFICATION_URL}";
else curl -X POST -H "Content-type: application/json" --data "${JSON_PAYLOAD_FAIL}" "${NOTIFICATION_URL}"
fi'
imagePullPolicy: Always
resources: {}
terminationMessagePath: /dev/termination-log
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
],
"description": "ACRFD API",
"keywords": [],
"license": "Apache 2.0",
"license": "Apache-2.0",
"main": "app",
"dependencies": {
"@turf/helpers": "^6.1.4",
Expand Down