Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/453: Onboard SPAR #487

Merged
merged 2 commits into from
Mar 11, 2023
Merged

Conversation

MCatherine1994
Copy link
Contributor

@MCatherine1994 MCatherine1994 commented Mar 10, 2023

  • onboard spar, create spar oidc client in terraform
  • add spar application, application client for all env, spar admin role for all env, and two testing roles "user_write" and "user_read" (got from SPAR team) for all env in db
  • update flyway infrastructure to pass cognito spar client id
  • update pipeline and docker-compose to put flyway placeholder for the spar client id, just random strings

- onboard spar, create spar oidc client
- add spar application, application client, admin role, and testing roles in db
refs: #453
@MCatherine1994 MCatherine1994 temporarily deployed to dev March 10, 2023 20:10 — with GitHub Actions Inactive
@MCatherine1994 MCatherine1994 temporarily deployed to dev March 10, 2023 20:12 — with GitHub Actions Inactive
@MCatherine1994 MCatherine1994 temporarily deployed to dev March 10, 2023 20:15 — with GitHub Actions Inactive
@MCatherine1994
Copy link
Contributor Author

Hi @ConradBoydElliottGustafson, the flyway test failed for auth function, I wonder if we should put some placeholder for the spar client id in both pipeline and docker compose file as for fom? are those random numbers?
image

Screen Shot 2023-03-10 at 12 43 12 PM

Screen Shot 2023-03-10 at 12 43 24 PM

- fix pipeline to add flyway placeholder for spar client id
- fix docker-compose file to add flyway placeholder for spar client id
- fix sql to use create user not update user for insert
- remove comma to fix snytax error
- update test cause we have 7 apps now
refs: #453
@MCatherine1994 MCatherine1994 temporarily deployed to dev March 10, 2023 21:41 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MCatherine1994 MCatherine1994 temporarily deployed to dev March 10, 2023 21:52 — with GitHub Actions Inactive
@MCatherine1994 MCatherine1994 temporarily deployed to dev March 10, 2023 22:11 — with GitHub Actions Inactive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! This PR will be the example for going forward with onboarding.

@ConradBoydElliottGustafson ConradBoydElliottGustafson deleted the feat/453-onboard-spar branch March 11, 2023 00:06
MCatherine1994 added a commit that referenced this pull request Mar 13, 2023
feat:
- onboard spar, merge the specific commit
@MCatherine1994
Copy link
Contributor Author

Don't forget to add the logout chain to the logout urls!!

@MCatherine1994
Copy link
Contributor Author

For the sql script to do insert, better to add ("on conflict (application_name, etc...") do nothing) for later easier fixing migration

@MCatherine1994
Copy link
Contributor Author

When create the new version of the flyway script, be careful about what's the current version is, and if main branch has another version, be careful!!

NickSaglioni pushed a commit that referenced this pull request Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants