-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/453: Onboard SPAR #487
Conversation
MCatherine1994
commented
Mar 10, 2023
•
edited
Loading
edited
- onboard spar, create spar oidc client in terraform
- add spar application, application client for all env, spar admin role for all env, and two testing roles "user_write" and "user_read" (got from SPAR team) for all env in db
- update flyway infrastructure to pass cognito spar client id
- update pipeline and docker-compose to put flyway placeholder for the spar client id, just random strings
- onboard spar, create spar oidc client - add spar application, application client, admin role, and testing roles in db refs: #453
Hi @ConradBoydElliottGustafson, the flyway test failed for auth function, I wonder if we should put some placeholder for the spar client id in both pipeline and docker compose file as for fom? are those random numbers? |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! This PR will be the example for going forward with onboarding.
feat: - onboard spar, merge the specific commit
Don't forget to add the logout chain to the logout urls!! |
For the sql script to do insert, better to add ("on conflict (application_name, etc...") do nothing) for later easier fixing migration |
When create the new version of the flyway script, be careful about what's the current version is, and if main branch has another version, be careful!! |