Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1540 create a user access history page #1607

Merged
merged 38 commits into from
Oct 3, 2024

Conversation

craigyu
Copy link
Collaborator

@craigyu craigyu commented Sep 25, 2024

Description:

Added a new screen for User Permission History

  • made my own bread crumbs component, the PrimeVue one is too hard to configure to work the way we want to
  • refactored the route logic to use hash router
  • cleaned up some styles that aren't scoped properly or abusing !important
  • added a new plugin Tanstack Query for managing data fetching and caching
  • added a new package luxon for date time manipulation and formatting
  • Implemented loading and error states for UserSummaryCard and the table

@craigyu craigyu self-assigned this Sep 25, 2024
@craigyu craigyu linked an issue Sep 25, 2024 that may be closed by this pull request
4 tasks
@craigyu craigyu linked an issue Sep 27, 2024 that may be closed by this pull request
2 tasks
@ianliuwk1019
Copy link
Collaborator

ianliuwk1019 commented Oct 1, 2024

Probably accidently the style gets broken in "Add delegated admin" user card:
image
Would you mind take a look? Thanks!

Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Craig, thanks for the frontend pr. Many good things I think you bring; some comments but more like questions, discussions and understanding (I am learning from you as well).

It's a lot of files changed, didn't initially expect this many in this pr so a bit slow on review, sorry about that. If you could keep the changes under some amount and create ticket if you see fit would be better than a big pr; but I understand sometimes it can be tricky doing that.
Thanks a lot.

frontend/src/App.vue Show resolved Hide resolved
frontend/src/alltypes.d.ts Show resolved Hide resolved
frontend/src/components/TableSkeleton/index.vue Outdated Show resolved Hide resolved
frontend/vite.config.ts Show resolved Hide resolved
frontend/src/static/sideNav.json Show resolved Hide resolved
frontend/src/components/common/SideNav.vue Show resolved Hide resolved
frontend/src/components/grantaccess/GrantAccess.vue Outdated Show resolved Hide resolved
frontend/src/views/UserDetails/index.vue Show resolved Hide resolved
@craigyu craigyu requested a review from ianliuwk1019 October 2, 2024 23:03
Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@craigyu craigyu merged commit 6b507c6 into main Oct 3, 2024
12 of 13 checks passed
@craigyu craigyu deleted the feat/1540-create-a-user-access-history-page branch October 3, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend user access history page integrates with Backend API Create a user access history page
2 participants