-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #1540 create a user access history page #1607
Conversation
# Conflicts: # frontend/src/components/managePermissions/table/UserDataTable.vue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Craig, thanks for the frontend pr. Many good things I think you bring; some comments but more like questions, discussions and understanding (I am learning from you as well).
It's a lot of files changed, didn't initially expect this many in this pr so a bit slow on review, sorry about that. If you could keep the changes under some amount and create ticket if you see fit would be better than a big pr; but I understand sometimes it can be tricky doing that.
Thanks a lot.
Quality Gate passed for 'nr-forests-access-management_admin'Issues Measures |
Description:
Added a new screen for User Permission History
!important
Tanstack Query
for managing data fetching and cachingluxon
for date time manipulation and formatting