Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FSADT1-1333): fixing client name on mail #995

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Jun 3, 2024

Description

Names do not match on different emails, due to the way the backend and the frontend acquire the logged user's first and last name. Fixed that by making both algorithms match.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • No new tests are required

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@github-actions github-actions bot added the fix label Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Current changelog

Bug Fixes

  • FSADT1-1333: fixing client name on mail (ef35586)
  • FSADT1-1333: idir name extraction (93e85c2)

@paulushcgcj paulushcgcj marked this pull request as ready for review June 3, 2024 22:01
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added fix and removed fix labels Jun 6, 2024
@paulushcgcj paulushcgcj requested a review from fterra-encora June 6, 2024 15:56
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@paulushcgcj paulushcgcj merged commit dc88260 into main Jun 6, 2024
22 checks passed
@paulushcgcj paulushcgcj deleted the fix/FSADT1-1333 branch June 6, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants