Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FSADT1-1346): add create client button to staff dashboard #984

Merged
merged 12 commits into from
Jun 3, 2024

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented May 30, 2024

Description

For staff users to be able to create a new client on behalf of someone else, we should add a button on the staff screen left-hand side menu, right below the existing dashboard button to allow staff users to create a new client. This button should only be visible and accessible to staff users with the correct role.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

  • New unit tests
  • New component tests
  • New end-to-end tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Contributor

github-actions bot commented May 30, 2024

Current changelog

Bug Fixes

  • FSADT1-1346: fixing tests with feature flag (1f81a2a)

Features

  • FSADT1-1346: add create client to staff dashboard (8582ad1)
  • FSADT1-1346: soft-locking feature behind a feature flag (83b0caa)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@paulushcgcj paulushcgcj enabled auto-merge (squash) May 30, 2024 19:52
@paulushcgcj paulushcgcj disabled auto-merge May 30, 2024 19:53
@github-actions github-actions bot added feature and removed feature labels May 30, 2024
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added feature and removed feature labels May 30, 2024
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added feature and removed feature labels May 30, 2024
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added feature and removed feature labels May 30, 2024
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Collaborator

@fterra-encora fterra-encora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I left a few comments.
I guess they are not very important, but I think it's preferable to just add the things I noticed.
Other than these comments, it looks great to me.

frontend/src/pages/FormStaffPage.vue Outdated Show resolved Hide resolved
frontend/src/pages/FormStaffPage.vue Outdated Show resolved Hide resolved
frontend/src/pages/FormStaffPage.vue Outdated Show resolved Hide resolved
frontend/src/pages/FormStaffPage.vue Outdated Show resolved Hide resolved
frontend/src/routes.ts Outdated Show resolved Hide resolved
frontend/src/components/MainHeaderComponent.vue Outdated Show resolved Hide resolved
frontend/src/components/MainHeaderComponent.vue Outdated Show resolved Hide resolved
@github-actions github-actions bot added feature and removed feature labels Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added feature and removed feature labels Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added feature and removed feature labels Jun 3, 2024
@paulushcgcj paulushcgcj requested a review from fterra-encora June 3, 2024 20:09
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@paulushcgcj paulushcgcj merged commit 70e097b into main Jun 3, 2024
22 checks passed
@paulushcgcj paulushcgcj deleted the feat/FSADT1-1346 branch June 3, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants