Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fe:FSADT1-1297): Prevent logout button cut out of the page #965

Merged
merged 21 commits into from
May 15, 2024

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented May 9, 2024

Description

  • Adapts the header according to screen size;
  • Fixes header buttons style on smaller screens;
  • Fixes the width of button Next - which also fixes some other screen issues;
  • Prevents layout break on the progress indicator.

Also fixes inputMode when input type is tel.

Note: some work had been made to allow resizing the header text responsively (so it wouldn't overflow the available area, so the buttons wouldn't get pushed out of the screen when its width is below 250px, or when width is below 500px and zoom is 200%).
But then we decided to cancel this fix.
So some css variable might not be really needed anymore but they shouldn't hurt.

Fixes FSADT1-1297

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)
  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@fterra-encora fterra-encora changed the title Fix/fsadt1 1297 [WIP] Fix/fsadt1 1297 May 9, 2024
@fterra-encora fterra-encora marked this pull request as ready for review May 9, 2024 19:23
Copy link
Contributor

github-actions bot commented May 10, 2024

Current changelog

Bug Fixes

  • adapt header according to screen size (25ba3c6)
  • cancel resizing the text on header (f3fbb94)
  • fix header buttons style on smaller screens (3255439)
  • fix inputMode when input type is tel (a7f3af7)
  • fix width of button Next (aac9e7f)
  • keep button Next on larger screens (068468d)
  • prevent layout break on progress indicator (76799c3)
  • resize header text (e532a6f)
  • resize header text responsively (7fee3ae)
  • take scroll bar width into account (48fd4a5)
  • use 20x20 icons on smaller breakpoints (7a11d9c)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@fterra-encora fterra-encora changed the title [WIP] Fix/fsadt1 1297 fix(fe:FSADT1-1297): Prevent logout button cut out of the page May 10, 2024
@github-actions github-actions bot added the fix label May 10, 2024
@github-actions github-actions bot added fix and removed fix labels May 10, 2024
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added fix and removed fix labels May 10, 2024
In case it's on the desktop.
@github-actions github-actions bot added fix and removed fix labels May 10, 2024
Actually for all breakpoints above 671px.
@github-actions github-actions bot added fix and removed fix labels May 13, 2024
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added fix and removed fix labels May 13, 2024
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added fix and removed fix labels May 15, 2024
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@fterra-encora fterra-encora merged commit 59cef60 into main May 15, 2024
22 checks passed
@fterra-encora fterra-encora deleted the fix/FSADT1-1297 branch May 15, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants