FSADT1-749 #482
Merged
FSADT1-749 #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamartinezmejia
requested review from
paulushcgcj and
brunoMarchiEncora
as code owners
github-actions
bot
added
backend
paulushcgcj
approved these changes
May 25, 2023
- SonarCloud improvements. - Related to FSADT1-749
- SonarCloud improvements. - Related to FSADT1-749
- SonarCloud improvements. - Related to FSADT1-749
|
[forest-client-frontend] Kudos, SonarCloud Quality Gate passed!
|
|
[nr-forest-client-backend] Kudos, SonarCloud Quality Gate passed! |
|
[nr-forest-client-processor] Kudos, SonarCloud Quality Gate passed!
|
paulushcgcj
pushed a commit
that referenced
this pull request
Jun 23, 2023
* FSADT1-749 * fix(be): - SonarCloud improvements. - Related to FSADT1-749 * fix(be): - SonarCloud improvements. - Related to FSADT1-749 * fix(be): - SonarCloud improvements. - Related to FSADT1-749 * chore: Refactor and improve existing unit tests * chore: Improve existing unit tests * Beautified code * Revert "chore: Improve existing unit tests" This reverts commit 1b2aa73. * no message * Revert "no message" This reverts commit 91115b5. * chore: updating tests * chore: updating tests * chore: updating tests * fix(be): - Fixed code smell issue * fix: updating ches auth procedure * fix: fixing ches mail test --------- Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]>
paulushcgcj
pushed a commit
that referenced
this pull request
Jul 11, 2023
…478) * feat(FE:FSADT1-772): adding stub server * feat(FE:FSADT1-772): updating radio to use new component * SonarCloud Frontend config * feat(FE:FSADT1-772): adding text input component * chore: reordering folders * ci: updating frontend sonar config * ci: fixing test command * SonarCloud adjustments * chore: updating files * feat(FE:FSADT1-772): adding new autocomplete component * ci: updating coverage details * chore: updating report config * chore(FE): changing sonar report to clover * fix(FE): fixing coverage report * chore(FE): changing radio button response * chore: fixing bootstrap component events - fixing bootstrap event consumption - updating AutoCompleteInputComponent and TextInputComponent to reflect above changes - updated tests for the above components - updatef form to reflect changes - added new type for the auto complete * feat(FE:FSADT1-772): updating form and components to carbon * chore: updating style - updating style of wizard - updating icons to carbon * chore: updating devcontainer and workspace * chore: removing debug code * feat(FE:FSADT1-785): updating business info * chore: adding type to ForestClientService.ts * chore: updating dtos * chore: updating stubs * chore: updating forms to reflect existing data * chore: updating some global styles * feat: adding new notification component * chore: updating pages * fix: fixing business info screen * fix: fix component initial value * chore: fixing form style * chore: fixing component labels * feat: adding wizard progress indicator component * chore: added bc gov sans font * chore: updating styles * feat(FE:FSADT1-785): adding review page - added review page - added function to navigate between steps * feat(fe): - Changed banner - Changed logo - Added common FSA styles * feat(fe): - Changed icon * chore: adding initial validators * chore: fixing style and adding validation - adding validators - updating validators - fixing some style issues - adding error handlig to all components * chore: stylying multi-select tags * chore: updating validators * chore: adding ignore case to unique validator * feat: adding modal and toast for delete - added modal - added toast notification - added remove address function - added remove contact function * chore: adding provide/inject to modal * feat: add links to progress indicator bar * feat: footer buttons change when review is ok * chore: updating workspace * chore: adding extension suggestion * chore: organize dependencies * chore: organize dependencies * chore: adding submission complete page and router * feat: adding form completion and updating route * chore: updating style * chore: updating modal mechanism to use vueuse * chore: readding vueuse * chore: code formatting * fix: autocomplete fetch when returning to screen * chore: updating to use pictograms * chore: updating toast * chore: changing icon for pictogram * chore: updating validators * feat: adding new inputmask for webcomponents * chore: updating stubs * chore: adding test content to the home page * chore: adding logout and exit in case of error * chore: updated MainHeader to carbon * chore: updating progress and style - updating progress indicator to add disabled state - updating styles to apply to shadow dom - updated business info to notify on errors - added inputmask definition helper - updated main to use non-deprecated types * fix: fixing file name * fix: fixing progress indicator * feat: adding mail message when duplicated * fix: removing vault due to inconsistency (#490) * chore(deps): update maven all non-major dependencies (#488) * chore(deps): update testcontainers-java monorepo to v1.18.3 * fix(deps): update dependency vite to v4.3.9 [security] * chore(deps): update maven all non-major dependencies * fix: removing vault due to inconsistency --------- Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]> * chore: clip digests (#484) * chore: clip digests * chore: removing unwanted files --------- Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]> * FSADT1-749 (#482) * FSADT1-749 * fix(be): - SonarCloud improvements. - Related to FSADT1-749 * fix(be): - SonarCloud improvements. - Related to FSADT1-749 * fix(be): - SonarCloud improvements. - Related to FSADT1-749 * chore: Refactor and improve existing unit tests * chore: Improve existing unit tests * Beautified code * Revert "chore: Improve existing unit tests" This reverts commit 1b2aa73. * no message * Revert "no message" This reverts commit 91115b5. * chore: updating tests * chore: updating tests * chore: updating tests * fix(be): - Fixed code smell issue * fix: updating ches auth procedure * fix: fixing ches mail test --------- Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]> * chore: updating codeowners (#492) Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]> * feat(BE:FSADT-745): updating mail template (#491) * no message * no message * FSADT1794 * feat:(BE:FSADT1-745): changing mail template contents * chore: removing unused files * chore: updating templates * chore: updating templates --------- Co-authored-by: Maria Martinez <[email protected]> Co-authored-by: Maria Martinez <[email protected]> * feat(be): (#493) - Made a minor change in the DB as per suggested by the DBAs (FSADT1-796) * feat(BE:FSADT1-794): updating content (#494) * no message * no message * FSADT1794 * feat:(BE:FSADT1-745): changing mail template contents * chore: removing unused files * chore: updating templates * chore: updating templates * fix(be): - Fixed code smells * feat(be): - Updated templates as per requested by Andrew (FSADT1-794) --------- Co-authored-by: Maria Martinez <[email protected]> Co-authored-by: Maria Martinez <[email protected]> * (FSADT1-796) Changes in the DB (#496) * feat(be): - Made a minor change in the DB as per suggested by the DBAs (FSADT1-796) * feat(be): - Added new column to store the unique identifier assigned to a contact --------- Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]> * chore(deps): update dependency c8 to v8 (#499) Co-authored-by: Renovate Bot <[email protected]> * chore(deps): update dependency jsdom to v22 (#500) Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]> * chore: updating package lock * chore: adding username * fix: fixing package lock * fix: fixing build - fixing build by removing unused dependencies - removing unused files * fix: adding vue tsc * chore: updating dockerfile * docs: updating extensions * fix: fixing invisible HR * chore: removing bootstrap * ci: fixing build * ci: fixing deployment order * chore: cleaning up the backend code * chore: adding submission info * chore: removing phone mask to check for validity * chore: trimming postal code * chore(temp): adding temporary presentation mail * feat: adding initial loading info to ac and fetcher * chore: adding data conversion - fixing legal and client type - adding data conversion for client type - using conversion * ci: adding platform for oracle db * chore: overwriting route * fix: fixing replace * fix: fixing BE build * fix: fixing BcRegistryExceptionMessageDto * fix: set state to invalid when business name input gets changed * chore: renaming dto and enabling to reflection * chore: setting content to 50% of screen * chore: adding margin to header * chore: fixing tab header space * chore: adding scroll to top * fix: reset data after form submission * fix(deps): update vitest monorepo to ^0.32.2 * chore: updating deploy check * fix: adding new CORS header keys * fix: fixing native build * fix: adding cors header manually * fix: adding new CORS header keys * ci: increasing resource due to constant restarts * chore: fixing dto property name * chore: adding location contact association * ci: fixing cypress test * ci: changing CHES to prod * fix(fe): - Fixed business name from proper keycloak key * chore: adding error log to ches * chore: adding ChesMailRequest to reflection * chore: adding ChesMailResponse to reflection * fix(fe): - Fixed typo * feat(fe): - Removed unused constants * chore: fixing unregistered client type * feat: adding global validator for submission * chore: updating stubs * chore: adding on-load validation check this is to force it to check for validity when changing screens, specially for when you move back to a tab * chore: cleanung up app.vue * chore: updating recommended extensions * chore: updating gitignore * chore: renaming components to short imports * chore: adding import back * chore(fe): - Made code reviews and beautified code * chore: changing colors * chore: removing field from buttons * chore: removing form reset * chore: updating autocomplete and textinput components * feat: address autocomplete stubs * feat(FE:FSADT1-812): add autocomplete to frontend * feat(BE:FSADT1-812): updating address backend api * fix(FE:FSADT1-805): fixing country not selected * chore: fixing loading image during api loading * fix: fixing dropdown updates * fix: fixing reset on province data after changes * chore: adding delay to some stub apis * chore: removing format on paste * feat(FE:FSADT1-812): adding loading on details loading and global error * feat: adding canada post api to deployment * chore: fire update:selected-value with undefined When the user changes the input value manually after a selection had been made. * test: emits update:selected-value * test: emit update:selected-value with new value * fix: remove duplicated error handler * test: fix element finding * test: fix expected text in the header * chore: moving composables to its own folder - aligning the composable functions we have to the standard vue folder structure - removing colors.ts as it wasn't being used * fix: fixing refactor issues * ci: fixing frontend build * chore: cleaning imports * chore: increasing coverage * chore: fixing code smell on backend * chore: fixing code smell on backend * chore: fixing sonar bugs * fix: removing unused components * fix(security): mitigating a few frontend security issues * chore: updating workspace and extensions * fix(codesmell): fixing codesmell * feat(fe): - FSADT1-811: Added logout fn * ci: adding vite node env as part of deployment * chore: updating lint and adding reformatted code * chore: simplifying keycloak loading and passing - refactored main.ts and App.vue to simplofy keyckload data - updated form page to consume the keycloak instance * fix(typescript:S905): fixing logout issue * fix: trying to disable sonar rules * test: updating coverage configuration * feat(fe): - Switching to FSA theme - Part #1 * fix: - Changed from px to rem - Added new overrides * test: updating coverage configuration * chore: adding lint dependencies * chore: updating validators and function signature * test: adding some tests * fix: - Added changes from the FSA theme repo temporarly * fix: fixing code smells * test: ignoring more files * chore: fixing code smell and adding new ignores * chore: refactoring files * test: ignoring files * chore: removing unused components * chore: refactoring component location * chore: removing default header * test: removing test * test: fixing existing tests warn messages * test: adding test * test: adding useFetch test * chore: updating components * feat(fe): - Switching to FSA theme - Part #2 * test: testing App.vue * fix: fixing dropdown initial value * chore: refactoring NoteComponent * chore: updating App test to mock header * chore: updating useFetch test * test: adding few more tests * test: adding multi select test * chore: removing main from coverage * ci: adding env configuration * feat(fe): - Switching to FSA theme - Part #3 * chore: fixing code smell * chore: updating gitignore * chore: updating vite configuration * test: adding/updating test dependencies * test(cypress): updating cypress configuration * test: adding HomePage component test * docs: updating gitignore * chore: updating/removing old cypress files * ci: updating frontend test configuration * test: updating some tests and test configuration * test: updating tests * chore: tweaking coverage results * chore: fixing bug * feat(FE:FSADT1-814): Vertical wizard (breadcrumb) (#515) * chore: display equal width for wizard steps And display ellipsis when text doesn't fit. * feat: display wizard steps vertically * test: display steps either vertically or horizontally * test: add more examples * style: format feature file * style: remove unused variable * chore: replace px units with rem * ci: fixing lcov report issue * feat(fe): - Switching to FSA theme - Part #4 * chore: removing dependency * chore: removing rm * chore: fixing nyc --------- Co-authored-by: Derek Roberts <[email protected]> Co-authored-by: Maria Martinez <[email protected]> Co-authored-by: Fernando Terra <[email protected]> Co-authored-by: BCGov-NR Renovate Bot <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Maria Martinez <[email protected]> Co-authored-by: Fernando Terra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow