FSADT1-722 #435
Merged
FSADT1-722 #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e using both client type and legal type
mamartinezmejia
requested review from
paulushcgcj and
brunoMarchiEncora
as code owners
github-actions
bot
added
backend
…e using both client type and legal type #2
…e using both client type and legal type #3
paulushcgcj
approved these changes
Apr 19, 2023
- Completed FSADT1-722
|
[forest-client-frontend] Kudos, SonarCloud Quality Gate passed!
|
paulushcgcj
pushed a commit
that referenced
this pull request
Apr 19, 2023
* fix(be): - Changed the version of the jacobo plugin as the version 0.8.9 was failing locally * fix(fe): - Fixed deprecation warning message indicating that the 'importsNotUsedAsValues' option will be removed in TypeScript 5.5, and we should use the 'verbatimModuleSyntax' instead. * Partial commit to get changes from Paulo * This code is not longer needed * Reverted changed. Done for testing purposes. * Changed named to legal name as the current one is misleading as we are using both client type and legal type * feat(fe): - Draft for https://apps.nrs.gov.bc.ca/int/jira/browse/FSADT1-722 * Changed named to legal name as the current one is misleading as we are using both client type and legal type #2 * Changed named to legal name as the current one is misleading as we are using both client type and legal type #3 * Uncommented out code * feat(fe): - Completed FSADT1-722 * chore: fixing tests --------- Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]>
paulushcgcj
pushed a commit
that referenced
this pull request
Apr 20, 2023
#436) * feat: adding proxy timeout config to legacy * fix: adding error handler to orgbook Some requests can return an error due to the amount of requests being done to orgbook. * fix: updating timeout for legacy * chore: removing unwanted endpoints * chore: removing unwanted endpoints * feat(BE:FSADT1-740): reworking submission to include list * chore: cleaning up validator * chore: removing submission from client * chore: refactoring ches service to include validation * chore: updating enum to be more flexible * chore: adding display name to make it easier to read * feat(BE:FSADT1-740): adding dto and predicates for search * chore: removing unwanted file * chore: simplifying validators * chore: renaming predicate class * chore: supressing warning * chore: code restructuring * chore: updating tests * FSADT1-722 (#435) * fix(be): - Changed the version of the jacobo plugin as the version 0.8.9 was failing locally * fix(fe): - Fixed deprecation warning message indicating that the 'importsNotUsedAsValues' option will be removed in TypeScript 5.5, and we should use the 'verbatimModuleSyntax' instead. * Partial commit to get changes from Paulo * This code is not longer needed * Reverted changed. Done for testing purposes. * Changed named to legal name as the current one is misleading as we are using both client type and legal type * feat(fe): - Draft for https://apps.nrs.gov.bc.ca/int/jira/browse/FSADT1-722 * Changed named to legal name as the current one is misleading as we are using both client type and legal type #2 * Changed named to legal name as the current one is misleading as we are using both client type and legal type #3 * Uncommented out code * feat(fe): - Completed FSADT1-722 * chore: fixing tests --------- Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]> --------- Co-authored-by: Maria Martinez <[email protected]>
This was referenced Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow