Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validation improvements #428

Merged
merged 22 commits into from
Apr 12, 2023
Merged

feat: validation improvements #428

merged 22 commits into from
Apr 12, 2023

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Apr 6, 2023 •
edited by github-actions bot
Loading

Description

Backend and frontend validation and improvements

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

mamartinezmejia and others added 21 commits April 3, 2023 13:02
@mamartinezmejia
no message
a1e0f5e
@mamartinezmejia
fix(fe/be):
eab9a9a 
- Fixed validation messages on the BE
- Fixed missing return in validation messages component
- Added missing validation in contacts section
- Refactored code in both FE and BE
- Beautified code
@mamartinezmejia
fix(be):
3742566 
- Fixed as per recommended (WhitespaceAround: '+' is not followed by whitespace.)
@mamartinezmejia
feat(be):
12b8122 
- Cleaned and organized imports
@mamartinezmejia
feat(fe/be):
afd3209 
- Improved code after code reviews
@mamartinezmejia
feat/fix(be):
19b6be7 
- Fixed unit testting bug
- Cleaned imports
- Beautified code for better readibility
@mamartinezmejia
Revert "feat(be):"
46a9940 
This reverts commit 12b8122.
@mamartinezmejia
fix(be):
69784dd 
- Made code reviews
@mamartinezmejia
fix(be):
090606e 
- Fixed code smell issues #1
@mamartinezmejia
fix(be):
4be8277 
- Removed extra separation in import group to satisfy SonarCloud
@mamartinezmejia
fix(be):
b93a3da 
- Fixed code smell issues #2
@mamartinezmejia
fix(be):
b33948b 
- Fixed code smell issues #3
@mamartinezmejia
fix(be):
1807c85 
- Code reviews: Defined a constant instead of duplicating literal
@mamartinezmejia
fix(be):
b112ab1 
- Reverted change as I had it before
@mamartinezmejia
fix(be):
657ddf4 
- Fixed typo
@mamartinezmejia
fix(be):
a75c5b5 
- Changed field to businessName as the incorporation number is hidden in the UI
@mamartinezmejia
fix(be):
942759a 
- Fixed based on code reviews standard
- Fixed code smells. Need to discuss this with the team as this doesn't make sense.
@mamartinezmejia
feat(fe):
c2e063b 
- Removed error msgs when value changes
feat(BE): updating bc registry to use document requisition
afe8746
@mamartinezmejia
feat(fe):
40046a3 
- FSADT1-736
@mamartinezmejia
fix(be):
3870c21 
- Changed wording as per suggested by Paulo
@mamartinezmejia mamartinezmejia marked this pull request as ready for review April 11, 2023 22:53
@github-actions github-actions bot added backend code related to the java backend application frontend java Pull requests that update Java code javascript Pull requests that update Javascript code source source code changes labels Apr 11, 2023
@github-actions github-actions bot added tests test classes changes feature labels Apr 11, 2023
@github-actions
Copy link
Contributor

Current changelog

Features

  • BE: updating bc registry to use document requisition (afe8746)

Reverts

@sonarqubecloud
Copy link

[forest-client-frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mamartinezmejia mamartinezmejia temporarily deployed to dev April 11, 2023 23:04 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev April 11, 2023 23:05 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev April 11, 2023 23:05 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev April 11, 2023 23:05 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev April 11, 2023 23:07 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia merged commit 645c19a into main Apr 12, 2023
@mamartinezmejia mamartinezmejia deleted the feat/fe-be-improvements branch April 12, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamartinezmejia mamartinezmejia mamartinezmejia approved these changes

@brunoMarchiEncora brunoMarchiEncora Awaiting requested review from brunoMarchiEncora

Assignees
No one assigned
Labels
backend code related to the java backend application feature frontend java Pull requests that update Java code javascript Pull requests that update Javascript code source source code changes tests test classes changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulushcgcj @mamartinezmejia