Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend improvements #289

Merged
merged 8 commits into from
Jan 31, 2023
Merged

Frontend improvements #289

merged 8 commits into from
Jan 31, 2023

Conversation

mamartinezmejia
Copy link
Collaborator

@mamartinezmejia mamartinezmejia commented Jan 30, 2023


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

- Renamed some fields to avoid confusions with HTML element properties - Part #1
- Beautifed code
- Renamed some fields to avoid confusions with HTML element properties - Part #2
- Renamed some fields to a more meaninful name
- Renamed some fields to a more meaninful name
- Change variable names to camel case as per agreed in the naming conventions
@github-actions github-actions bot added frontend javascript Pull requests that update Javascript code source source code changes labels Jan 30, 2023
@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fe: (#269) (a3417bd)
  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fe: (#269) (a3417bd)
  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@mamartinezmejia mamartinezmejia temporarily deployed to dev January 30, 2023 23:09 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev January 30, 2023 23:09 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev January 30, 2023 23:09 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev January 30, 2023 23:09 — with GitHub Actions Inactive
- Refactored test scripts based on the recent chages
- Fixed typo
@github-actions github-actions bot added the tests test classes changes label Jan 31, 2023
@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fe: (#269) (a3417bd)
  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@mamartinezmejia mamartinezmejia temporarily deployed to dev January 31, 2023 19:17 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev January 31, 2023 19:17 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev January 31, 2023 19:17 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev January 31, 2023 19:17 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

[forest-client-frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fe: (#269) (a3417bd)
  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@mamartinezmejia mamartinezmejia temporarily deployed to dev January 31, 2023 19:57 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev January 31, 2023 19:57 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev January 31, 2023 19:57 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev January 31, 2023 19:57 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia merged commit ba0f971 into main Jan 31, 2023
@mamartinezmejia mamartinezmejia deleted the feat/fe/frontend-improvements branch January 31, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend javascript Pull requests that update Javascript code source source code changes tests test classes changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant