Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(be:FSADT1-500) adding oracle legacy code #268

Merged
merged 54 commits into from
Feb 8, 2023
Merged

feat(be:FSADT1-500) adding oracle legacy code #268

merged 54 commits into from
Feb 8, 2023

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Jan 23, 2023 •
edited by github-actions bot
Loading

Description

Reintroducing the oracle data layer, now into its own project. The idea is to have some APIs to be consumed by both the frontend and the backend application.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Automated integration tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

This will generate changes on the deployment process by adding a new service.

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Paulo Gomes da Cruz Junior added 14 commits January 12, 2023 13:59
feat(be:FSADT1-500): creating legacy forest client
90fb838 
- adding oracle code back to the code base
- creating new deployment for legacy
feat(be:FSADT1-500): adding some other apis
ed6dbac 
- adding first nation band validation
- adding client doing business list

it still requires some code to be extracted from here and backend and moved to an external library, but it will be dealt with in the future
feat(be:FSADT1-500): adding last endpoint
80d026b 
- added unregistered clients endpoint
chore: updating some dtos
b57fb19
chore: updating entities
6db228e 
moving schema info from constant to configuration to help with tests
chore: updating search and adding tests
b1fd4f3
test: updating testcontainer and adding flyway
a85e835
test: refactored entities to pass schema
45c676d
test: refactored entities to pass schema
d33ca11
test: adding tests for search by name and birth
56ab47a 
- added test classes
- reverted the constant back
- updated the client
- updated the repository
- moved to search by example approach
ci: updating ci and compose
f7680ae 
- adding oracle db to compose
- updating readme for a draft version
chore: adding configuration classes
2b28cd8
chore: adding handlers and service
a8ac479
Merge branch 'main' into feat/be/FSADT1-500
784b8a3
@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@paulushcgcj paulushcgcj temporarily deployed to dev January 23, 2023 22:22 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev January 23, 2023 22:22 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev January 23, 2023 22:22 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev January 23, 2023 22:22 — with GitHub Actions Inactive
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Jan 25, 2023
@github-actions
Copy link
Contributor

Current changelog

Bug Fixes

  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@paulushcgcj paulushcgcj temporarily deployed to dev January 25, 2023 22:12 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev January 25, 2023 22:12 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev January 25, 2023 22:12 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev January 25, 2023 22:12 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj mentioned this pull request Jan 26, 2023
Closed
@paulushcgcj paulushcgcj temporarily deployed to dev February 8, 2023 02:01 — with GitHub Actions Inactive
DerekRoberts
DerekRoberts previously requested changes Feb 8, 2023
View reviewed changes
legacy/Dockerfile Fixed Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Current changelog

Bug Fixes

Features

Reverts

@paulushcgcj paulushcgcj temporarily deployed to dev February 8, 2023 16:15 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 8, 2023 16:15 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 8, 2023 16:15 — with GitHub Actions Inactive
@github-actions github-actions bot added frontend javascript Pull requests that update Javascript code labels Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Current changelog

Bug Fixes

Features

Reverts

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2023

[forest-client-frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@paulushcgcj paulushcgcj temporarily deployed to dev February 8, 2023 16:23 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 8, 2023 16:23 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 8, 2023 16:23 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 8, 2023 16:23 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 8, 2023 16:39 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 8, 2023 16:39 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 8, 2023 16:39 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 8, 2023 16:39 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 8, 2023 16:39 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj dismissed DerekRoberts’s stale review February 8, 2023 17:09

Changes were applied

@paulushcgcj paulushcgcj merged commit 768cc8c into main Feb 8, 2023
@paulushcgcj paulushcgcj deleted the feat/be/FSADT1-500 branch February 8, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamartinezmejia mamartinezmejia mamartinezmejia approved these changes

@brunoMarchiEncora brunoMarchiEncora Awaiting requested review from brunoMarchiEncora

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

Assignees
No one assigned
Labels
backend code related to the java backend application configuration changes related to configuration file database frontend github_actions Pull requests that update GitHub Actions code java Pull requests that update Java code javascript Pull requests that update Javascript code openshift source source code changes tests test classes changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulushcgcj @DerekRoberts @mamartinezmejia