fix(fe:FSADT1-1521): clear the AutoComplete field when preventSelection is true #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current changelogBug Fixes
Features
|
|
mamartinezmejia
approved these changes
Oct 10, 2024
21 tasks
fterra-encora
added a commit
that referenced
this pull request
Oct 17, 2024
* feat(FSADT1-1519): Draft for Create API endpoint for predictive search * Added temporary feature flag for the search functionality * feat(FSADT1-1519): Predictive search endpoint #1 * feat(FSADT1-1519): Predictive search #2 * feat(be:FSADT1-1519): Create API endpoint for predictive search * feat(be:FSADT1-1519): Create API endpoint for predictive search * chore: Added javadocs * Removed unused imports * feat(be:FSADT1-1519): Create API endpoint for predictive search * Refactored code and included full seach * Refactored code to have 1 query only * Added count in the API * feat(fe:FSADT1-1541): Display an error message when the BE is down (#1227) * feat(fe:FSADT1-1521): create the predictive search (#1223) * feat: add search box with predictive search * fix: fix predictive-search stubs * feat: update style of search controls * docs: update interface name * fix: use placeholder instead of label * test: add search test file * feat: navigate to client details * test: implement tests * refactor: move functions to the GlobalValidators * feat: validate autocomplete while typing * feat: validate keywords * test: validate keywords * feat: prevent selection on AutoComplete * feat: open client details in a new tab * chore: update endpoint stub * test: update tests * feat(fe:FSADT1-1541): Display an error message when the BE is down (#1227) * fix: rename event from click to click:option --------- Co-authored-by: Maria Martinez <[email protected]> * Renamed files * Added missing key * fix(fe:FSADT1-1521): clear the AutoComplete field when preventSelection is true (#1230) * test: fix tests * fix: do not prevent the clearing action * Added stubs for full search * fix: apply the feature flag to the Client search button And remove it from the check of user's authority. * chore: add header x-total-count to stub * feat: add css tag colors from nr-theme * feat: set status tag colors * fix: prevent emitting the full css theme * feat: emit press:enter * fix: prevent emitting press:enter when it's a selection * feat: update full search behavior * feat: prevent search with invalid value * fix: reset error message * fix: remove optional from validations * chore: update stub file * fix: display empty acronyms Also sets column widths * test: check results by index * fix: fix displaying issue on status column Also updates css class names * test: add more tests * fix: allow empty search * test: search with no keywords --------- Co-authored-by: Maria Martinez <[email protected]> Co-authored-by: Maria Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for #1223.
Stops preventing the action to clear the input value when preventSelection is true.
And also fixes tests that broke after updates on feat/client3.
Fixes FSADT1-1521
Type of change
How Has This Been Tested?
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: