Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FSADT1-1537): increasing rate limiter #1213

Merged
merged 8 commits into from
Oct 7, 2024
Merged

fix(FSADT1-1537): increasing rate limiter #1213

merged 8 commits into from
Oct 7, 2024

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Oct 7, 2024 •
edited by github-actions bot
Loading

Description

Increased the rate limiter values. This is to prevent autocomplete from being blocked due to typing speed

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • No new tests are required
  • Manual tests (description below)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

To replicate the issue, type fast into any autocomplete field. This should trigger the request for each character

Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@paulushcgcj
fix(FSADT1-1537): increasing rate limiter
c5df50a 
This is to prevent autocomplete from being blocked due to typing speed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited
Loading

Current changelog

Bug Fixes

  • FSADT1-1537: adding more limited partnership associations (b1027cd)
  • FSADT1-1537: fixing missing association (2d444c5)
  • FSADT1-1537: increasing rate limiter (c5df50a)

Features

  • FSADT1-1537: added debounce time to autocomplete (8b8c47a)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@paulushcgcj paulushcgcj enabled auto-merge (squash) October 7, 2024 16:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@paulushcgcj paulushcgcj merged commit 5b6b61e into main Oct 7, 2024
24 checks passed
@paulushcgcj paulushcgcj deleted the fix/FSADT1-1537 branch October 7, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamartinezmejia mamartinezmejia mamartinezmejia approved these changes

@fterra-encora fterra-encora Awaiting requested review from fterra-encora fterra-encora is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulushcgcj @mamartinezmejia