Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FSADT1-1483): updated filter of hot/cold requests #1137

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Sep 3, 2024

Description

  • Added filter only to allow hot requests to proceed
  • Added hot/cold filter to the processor

This change will check if a submission is HOT or COLD.

A HOT submission can be processed, by checking if the timing of processing is bigger than 2 minutes.

A COLD submission is being processed already, and we check that by the processing time if it is smaller than 2 minutes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • No new tests are required

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

- Added filter to only allow hot requests to proceed
- Added hot/cold filter to the processor

 This change will check if a submission is HOT or COLD.

 A HOT submission is one that can be processed, by checking if the timing of processing is bigger than 2 minutes.

 A COLD submission is one that is being processed already, and we check that by the processing time if it is smaller than 2 minutes.
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Current changelog

Bug Fixes

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@paulushcgcj paulushcgcj merged commit 985c27c into main Sep 3, 2024
22 checks passed
@paulushcgcj paulushcgcj deleted the fix/FSADT1-1483 branch September 3, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants