Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FSADT1-1439|FSADT1-1441): Review page updates #1091

Merged
merged 9 commits into from
Aug 20, 2024
Merged

feat(FSADT1-1439|FSADT1-1441): Review page updates #1091

merged 9 commits into from
Aug 20, 2024

Conversation

mamartinezmejia
Copy link
Collaborator

@mamartinezmejia mamartinezmejia commented Aug 19, 2024 •
edited by github-actions bot
Loading

Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024 •
edited
Loading

Current changelog

Features

  • fe:FSADT1-1439: Individual (31c4c56)
  • fe:FSADT1-1439: Others (caef33d)
  • fe:FSADT1-1440: Locations - Review Page (7a86a4d)
  • fe:FSADT1-1441: Contacts - Part #2 (8e51299)
  • fe:FSADT1-1441: Contacts - Part#1 (9961735)

@mamartinezmejia mamartinezmejia marked this pull request as ready for review August 20, 2024 16:36
@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

paulushcgcj
paulushcgcj requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@paulushcgcj paulushcgcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the addition of the new endpoint being called on the review page, we need to also include the stub for it on the stub folder, along with the intercept calls for the cypress tests where is needed

@paulushcgcj paulushcgcj changed the title feat(FSADT1-1439-1441): Review page updates feat(FSADT1-1439|FSADT1-1441): Review page updates Aug 20, 2024
@mamartinezmejia mamartinezmejia removed the request for review from fterra-encora August 20, 2024 19:58
@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@mamartinezmejia mamartinezmejia enabled auto-merge (squash) August 20, 2024 23:27
@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@mamartinezmejia mamartinezmejia merged commit 3c3bd6c into main Aug 20, 2024
21 checks passed
@mamartinezmejia mamartinezmejia deleted the feat/fe/FSADT1-1439-1441 branch August 20, 2024 23:39
@github-actions github-actions bot mentioned this pull request Aug 20, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulushcgcj paulushcgcj paulushcgcj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamartinezmejia @paulushcgcj