Skip to content

Commit

Permalink
chore: Removed STAFF_CREATE temporary flag (#1158)
Browse files Browse the repository at this point in the history
  • Loading branch information
mamartinezmejia authored Sep 16, 2024
1 parent 42c6560 commit a92aa98
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion frontend/openshift.configmap.dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ objects:
name: ${NAME}-${ZONE}-${COMPONENT}-config
data:
params.js: |
window.localStorage.setItem('VITE_FEATURE_FLAGS','{"STAFF_CREATE":true}');
window.localStorage.setItem('VITE_FEATURE_FLAGS','{}');
2 changes: 1 addition & 1 deletion frontend/openshift.configmap.test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ objects:
name: ${NAME}-${ZONE}-${COMPONENT}-config
data:
params.js: |
window.localStorage.setItem('VITE_FEATURE_FLAGS','{"STAFF_CREATE":true}');
window.localStorage.setItem('VITE_FEATURE_FLAGS','{}');
6 changes: 3 additions & 3 deletions frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"scripts": {
"start": "vite --host --port 3000",
"build": "vue-tsc --noEmit && vite build",
"preview": "cross-env VITE_NODE_ENV=test VITE_FEATURE_FLAGS={\\\"STAFF_CREATE\\\":true} start-server-and-test stub http://127.0.0.1:8080 start",
"preview": "cross-env VITE_NODE_ENV=test start-server-and-test stub http://127.0.0.1:8080 start",
"preview:app": "cross-env VITE_NODE_ENV=test vite --host --port 3000",
"typecheck": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false",
"lint": "eslint . --fix --ignore-path .gitignore",
Expand All @@ -36,12 +36,12 @@
"posttest:component": "mv reports/.nyc_report reports/component",
"test:unit": "cross-env VITE_NODE_ENV=test NODE_ENV=test vitest run --coverage",
"posttest:unit": "mv reports/.vite_report reports/unit",
"test:e2e": "cross-env VITE_NODE_ENV=test VITE_FEATURE_FLAGS={\\\"STAFF_CREATE\\\":true} start-server-and-test preview http://127.0.0.1:3000 'cypress run --headless'",
"test:e2e": "cross-env VITE_NODE_ENV=test start-server-and-test preview http://127.0.0.1:3000 'cypress run --headless'",
"posttest:e2e": "mv reports/.nyc_report reports/e2e",
"pretest:report:merge": "rm -rf reports-merge && mkdir -p reports-merge && for name in component e2e unit; do cp reports/$name/coverage-final.json reports-merge/$name.json; done",
"test:report:merge": "mkdir -p .nyc_output && rm -rf coverage && nyc --config nyc.config.json merge reports-merge && mv coverage.json .nyc_output/out.json && nyc --config nyc.config.json report --reporter lcov --reporter text-summary --report-dir coverage --temp-dir .nyc_output",
"test:report:clean": "rm -rf reports && mkdir -p reports/.nyc_output/processinfo && mkdir -p coverage",
"test:build": "cross-env VITE_MODE=test VITE_NODE_ENV=test VITE_FEATURE_FLAGS={\\\"STAFF_CREATE\\\":true} start-server-and-test preview http://127.0.0.1:3000 'cypress open'",
"test:build": "cross-env VITE_MODE=test VITE_NODE_ENV=test start-server-and-test preview http://127.0.0.1:3000 'cypress open'",
"test:flush": "rm -rf reports && rm -rf .nyc_output && rm -rf coverage && rm -rf reports-merge",
"posttest:flush": "npm run coverage",
"test:unit:devtools": "cross-env VITE_NODE_ENV=test NODE_ENV=test vitest run --inspect-brk --pool threads --poolOptions.threads.singleThread"
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/MainHeaderComponent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ const logoutBtnKind = computed(() =>
isSmallScreen.value || isMediumScreen.value ? "ghost" : "tertiary",
);
const userHasAuthority = ["CLIENT_EDITOR", "CLIENT_ADMIN"].some(authority => ForestClientUserSession.authorities.includes(authority)) && featureFlags.STAFF_CREATE;
const userHasAuthority = ["CLIENT_EDITOR", "CLIENT_ADMIN"].some(authority => ForestClientUserSession.authorities.includes(authority));
</script>

<template>
Expand Down
3 changes: 1 addition & 2 deletions frontend/src/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,7 @@ export const routes = [
style: "content-stretched",
headersStyle: "headers-compact",
sideMenu: true,
profile: true,
featureFlagged: "STAFF_CREATE",
profile: true
},
},
{
Expand Down

0 comments on commit a92aa98

Please sign in to comment.