fix(be):

- Fixed unit tests after recent changes
bcgov · Mar 9, 2023 · 96b523e · 96b523e
1 parent b552888
commit 96b523e
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 10 deletions.
diff --git a/backend/src/main/java/ca/bc/gov/app/dto/client/ClientContactDto.java b/backend/src/main/java/ca/bc/gov/app/dto/client/ClientContactDto.java
@@ -2,7 +2,8 @@
 
 public record ClientContactDto(
     String contactType,
-    String name,
+    String firstName,
+    String lastName,
     String businessPhone,
     String email,
     int index

diff --git a/backend/src/main/java/ca/bc/gov/app/entity/client/SubmissionLocationContactEntity.java b/backend/src/main/java/ca/bc/gov/app/entity/client/SubmissionLocationContactEntity.java
@@ -24,8 +24,11 @@ public class SubmissionLocationContactEntity {
   @Column("submission_location_id")
   private Integer submissionLocationId;
 
-  @Column("name_department")
-  private String nameDepartment;
+  @Column("first_name")
+  private String firstName;
+
+  @Column("last_name")
+  private String lastName;
 
   @Column("contact_type_code")
   private String contactTypeCode;

diff --git a/backend/src/main/java/ca/bc/gov/app/entity/client/SubmissionLocationEntity.java b/backend/src/main/java/ca/bc/gov/app/entity/client/SubmissionLocationEntity.java
@@ -39,9 +39,6 @@ public class SubmissionLocationEntity {
   @Column("postal_code")
   private String postalCode;
 
-  @Column("business_phone_number")
-  private String businessPhoneNumber;
-
   @Column("email_address")
   private String emailAddress;
 

diff --git a/backend/src/main/java/ca/bc/gov/app/util/ClientMapper.java b/backend/src/main/java/ca/bc/gov/app/util/ClientMapper.java
@@ -41,7 +41,6 @@ public static SubmissionLocationEntity mapToSubmissionLocationEntity(
         .withProvinceCode(clientAddressDto.province())
         .withCityName(clientAddressDto.city())
         .withPostalCode(clientAddressDto.postalCode())
-        .withBusinessPhoneNumber(clientAddressDto.businessPhone())
         .withEmailAddress(clientAddressDto.email());
   }
 
@@ -51,7 +50,8 @@ public static SubmissionLocationContactEntity mapToSubmissionLocationContactEnti
   ) {
     return new SubmissionLocationContactEntity()
         .withSubmissionLocationId(submissionLocationId)
-        .withNameDepartment(clientContactDto.name())
+        .withFirstName(clientContactDto.firstName())
+        .withLastName(clientContactDto.lastName())
         .withContactTypeCode(clientContactDto.contactType())
         .withBusinessPhoneNumber(clientContactDto.businessPhone())
         .withEmailAddress(clientContactDto.email());

diff --git a/backend/src/test/java/ca/bc/gov/app/endpoints/client/ClientHandlerIntegrationTest.java b/backend/src/test/java/ca/bc/gov/app/endpoints/client/ClientHandlerIntegrationTest.java
@@ -202,8 +202,12 @@ void shouldSubmitClientData() {
                         0,
                         List.of(
                             new ClientContactDto(
-                                "LP", "James", "007",
-                                "[email protected]", 0))
+                                "LP", 
+                                "James", 
+                                "Doe",
+                                "007",
+                                "[email protected]", 
+                                0))
                     )))
         );
     client