Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25209 - make reason change permanent only if there was change in name. #227

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

hfekete
Copy link
Collaborator

@hfekete hfekete commented Jan 28, 2025

Issue:25209bcgov/entity#25209

Description of changes:
make reason change required only if there was change in name.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@hfekete hfekete self-assigned this Jan 28, 2025
@hfekete
Copy link
Collaborator Author

hfekete commented Jan 28, 2025

/gcbrun

@bcregistry-sre
Copy link
Collaborator

bcregistry-sre commented Jan 28, 2025

@hfekete
Copy link
Collaborator Author

hfekete commented Jan 29, 2025

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-btr-dev--pr-227-byyfx9is.web.app

Copy link
Collaborator

@patrickpeinanw patrickpeinanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just a reminder to update the ticket number in the PR title. I think it should be #25209

@hfekete hfekete changed the title 25203 - make reason change permanent only if there was change in name. 25209 - make reason change permanent only if there was change in name. Jan 29, 2025
@hfekete hfekete merged commit 738db29 into bcgov:main Jan 29, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants