8438 cooperative schema update #65
Conversation
| "cooperativeAssociationType": { | ||
| "type": "string", | ||
| "title": "The association type for cooperative filing" |
There was a problem hiding this comment.
This could be an enum. We can do that once values are available.
| @@ -92,4 +94,6 @@ | |||
| 'TRANSITION', | |||
| 'TRANSITION_FILING_TEMPLATE', | |||
| 'UNMANAGED', | |||
| 'COOP_INCORPORATION', | |||
There was a problem hiding this comment.
please keep in alphabetical order
| @@ -1612,6 +1693,24 @@ | |||
| } | |||
| } | |||
|
|
|||
| COOP_INCORPORATION_FILING_TEMPLATE = { | |||
| 'filing': { | |||
There was a problem hiding this comment.
Use the FILING_HEADER, easier to keep current
| 'email': '[email protected]', | ||
| 'phone': '123-456-7890' | ||
| }, | ||
| 'cooperative': { |
There was a problem hiding this comment.
I wonder if we can start making the examples fit the same as the schema definition?
a value for _ cooperative_ that is then added to the base incorporation?
There was a problem hiding this comment.
Do you suggest to include cooperative in incorporation (example) itself?
There was a problem hiding this comment.
in the default incorporation (core) no.
I think we should split these out so that we end up with core, and then IA-, ben, ltd, coop, etc.
| @@ -51,8 +49,40 @@ | |||
| }, | |||
| "nameTranslations": { | |||
| "$ref": "https://bcrs.gov.bc.ca/.well_known/schemas/name_translations" | |||
| }, | |||
| "cooperative": { | |||
There was a problem hiding this comment.
change this so it's its own section like nameRequest
and then keep it in alpha order
src/registry_schemas/version.py
Outdated
| @@ -22,4 +22,4 @@ | |||
| Development release segment: .devN | |||
| """ | |||
|
|
|||
| __version__ = '2.13.1' # pylint: disable=invalid-name | |||
| __version__ = '2.13.2' # pylint: disable=invalid-name | |||
There was a problem hiding this comment.
i mucked the numbers, will need to be 2.14.0
|
I'm going to merge as I need to add in restoration and I don't want you to have to rebase on that for a simple change. |
Issue #: /bcgov/entity#8438
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).