Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema changes - Transition filing #47

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Conversation

lmallika86
Copy link

@lmallika86 lmallika86 commented Oct 20, 2020

Issue #: /bcgov/entity#5182

Description of changes:
Added the schema and sample data for a transition filing
Added tests

All the business specific information like identifier, legal type and legal name will be present in the business section of the filing outside the transition object. As we are not altering any of the business specific info, it need not be present inside the transition object

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@lmallika86 lmallika86 self-assigned this Oct 20, 2020
Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Collaborator

@thorwolpert thorwolpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 question on provisions.

src/registry_schemas/schemas/transition.json Show resolved Hide resolved
@thorwolpert
Copy link
Collaborator

thanks!!

@lmallika86 lmallika86 merged commit 5e78850 into bcgov:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants