Skip to content

Commit

Permalink
24772 - Update NoW Schema (#172)
Browse files Browse the repository at this point in the history
* 24772-Update-NoW-Schema-and-data-with-new-properties

* 24772-Change-id-to-singular

* 24772-Update titles for new properties
  • Loading branch information
meawong authored Jan 23, 2025
1 parent e7be133 commit ac4ecce
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 4 deletions.
4 changes: 3 additions & 1 deletion src/registry_schemas/example_data/schema_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -2889,7 +2889,9 @@

NOTICE_OF_WITHDRAWAL = {
'filingId': 123,
'courtOrder': COURT_ORDER
'courtOrder': COURT_ORDER,
'hasTakenEffect': False,
'partOfPoa': False
}

# build complete list of filings with names, for use in the generic test_valid_filing() test
Expand Down
12 changes: 10 additions & 2 deletions src/registry_schemas/schemas/notice_of_withdrawal.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,17 @@
"properties": {
"filingId": {
"type": "integer",
"title": "IDs for the FED filings."
"title": "ID for the FED filing."
},
"courtOrder": { "$ref": "https://bcrs.gov.bc.ca/.well_known/schemas/court_order#/properties/courtOrder" }
"courtOrder": { "$ref": "https://bcrs.gov.bc.ca/.well_known/schemas/court_order#/properties/courtOrder"},
"hasTakenEffect": {
"type": "boolean",
"title": "One of the terms of arrangement for the FED filing have taken effect"
},
"partOfPoa": {
"type": "boolean",
"title": "FED filing is part of a Plan of Arrangement"
}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/registry_schemas/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@
"""


__version__ = '2.18.32' # pylint: disable=invalid-name
__version__ = '2.18.33' # pylint: disable=invalid-name

0 comments on commit ac4ecce

Please sign in to comment.