Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24524 24701 fix date format in tombstone #99

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

patrickpeinanw
Copy link
Collaborator

@patrickpeinanw patrickpeinanw commented Dec 6, 2024

*Issue:*bcgov/entity#24524
*Issue:*bcgov/entity#24701

Description of changes:

Fix date format for historical reason.

Fix date format for 'active until' for limited restoration.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@patrickpeinanw patrickpeinanw self-assigned this Dec 6, 2024
@patrickpeinanw
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-99-id8t0fbc.web.app

@patrickpeinanw
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-99-id8t0fbc.web.app

Copy link
Collaborator

@hfekete hfekete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@patrickpeinanw
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-99-id8t0fbc.web.app

@patrickpeinanw patrickpeinanw marked this pull request as ready for review December 6, 2024 17:14
@patrickpeinanw patrickpeinanw merged commit 5bf6a72 into bcgov:main Dec 6, 2024
6 checks passed
@severinbeauvais
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants