Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24755 - fix: when and how is account fetched. #98

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

hfekete
Copy link
Collaborator

@hfekete hfekete commented Dec 6, 2024

Issue:24755bcgov/entity#24755

Description of changes:
fix: when and how is account fetched.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@hfekete
Copy link
Collaborator Author

hfekete commented Dec 6, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-98-dnwl9ptp.web.app

Copy link
Collaborator

@BrandonSharratt BrandonSharratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the requested ticket and looks good to me. I do wish that the account selector would be enabled on the error page when one account has access and you happen to be in one that doesn't but that is out of scope for this ticket and covered in a different ticket.

@hfekete hfekete merged commit 4e8fdac into bcgov:main Dec 6, 2024
6 checks passed
@severinbeauvais
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants