24502 - add modal for invalid name request and re-organize error page #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpeinanw
requested review from
hfekete,
BrandonSharratt and
severinbeauvais
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-90-un4amkde.web.app SB says, try this: https://business-dashboard-dev--pr-90-un4amkde.web.app/TcueIT8yIP?accountid=668 |
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-90-un4amkde.web.app |
hfekete
approved these changes
Dec 3, 2024
severinbeauvais
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue:*bcgov/entity#24502
Description of changes:
Now the error page has three different scenarios:
Note: in Filing UI, the header for Invalid Name Request is always "Invalid Incorporation Application", in the new dashboard, the dialog header is "Invalid Name Request".
Screenshots for different types of invalid name request (taken from the cypress test)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).