fix missing files for boostrap incorporation filing #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-89-x16xbutk.web.app Example broken in dev: https://business-dashboard-dev.web.app/Ty3skQHARX |
BrandonSharratt
requested review from
hfekete,
patrickpeinanw and
severinbeauvais
| @@ -6,7 +6,7 @@ | |||
| <span v-else-if="isTypeDissolutionVoluntary">{{ $t('text.filing.futureEffectiveDissolution') }}</span> | |||
| <span v-else>{{ $t('text.filing.futureEffectiveFiling') }}</span> | |||
| <span> | |||
| {{ $t('text.filing.paid') }} | |||
| {{ ' ' + $t('text.filing.paid') }} | |||
There was a problem hiding this comment.
FYI, you can also use to add a space. (No need to change your code.)
severinbeauvais
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue:*bcgov/entity#24541
Description of changes:
The bootstrap filing loader was not getting certain things from the correct spot for instance, the documentsLink so I fixed them as an || incase there was some case I was missing where they are in that field.
Additionally there was no space for future effective filings between the filing name and PAID so I added one.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).