Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24464 - fix: iron out discrepancies in use of FF between current and new (this) dashboard. #85

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

hfekete
Copy link
Collaborator

@hfekete hfekete commented Nov 28, 2024

*Issue:24464 *bcgov/entity#24464

Description of changes:

  • implement new FF 'businesses-to-manage-in-colin'
  • verify other flags are used, and in proper places:
    • supported-agm-extension-entities
    • supported-agm-location-chg-entities
    • supported-amalgamation-entities
    • supported-business-summary-entities
    • supported-consent-continuation-out-entities
    • supported-correction-entities
    • supported-put-back-on-entities
    • supported-restoration-entities

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@hfekete hfekete self-assigned this Nov 28, 2024
@severinbeauvais
Copy link
Collaborator

Please create the preview site, please provide a sample business, and please fix the broken Cypress test(s).

@@ -10,6 +10,7 @@ interface MenuActionItem extends DropdownItem {

const filings = useBcrosFilings()
const business = useBcrosBusiness()
const { getStoredFlag } = useBcrosLaunchdarkly()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about your implementation of the LD client so I looked at your code. Why don't you have streaming enabled? That would get you real-time flag updates, I think...?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how that works, but I like the idea, will look into it when I get time for it. Thanks !

@hfekete hfekete merged commit a42fca0 into bcgov:main Nov 28, 2024
5 of 6 checks passed
@hfekete
Copy link
Collaborator Author

hfekete commented Nov 28, 2024

/gcbrun

@hfekete
Copy link
Collaborator Author

hfekete commented Nov 28, 2024

testing details (staff account in dev to test)
C9900819?accountid=3040

@hfekete
Copy link
Collaborator Author

hfekete commented Nov 28, 2024

Can be tested in dev, as the merge does not allow preview anymore :/

https://business-dashboard-dev.web.app/C9900819?accountid=3040

@severinbeauvais
Copy link
Collaborator

https://business-dashboard-dev.web.app/C9900819?accountid=3040

Hey, did you notice this?

image

FYI:
C = continued in BC (title should be same as BC)
CBEN = continued in BEN (title should be same as BEN)
CCC = continued in CC (title should be same as CC)
CUL = continued in ULC (title should be same as ULC)

@severinbeauvais
Copy link
Collaborator

https://business-dashboard-dev.web.app/C9900819?accountid=3040

image

This should also display an alert. Compare with https://dev.business.bcregistry.gov.bc.ca/C9900819?accountid=3040. Please create a new ticket if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants