-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24464 - fix: iron out discrepancies in use of FF between current and new (this) dashboard. #85
Conversation
…w (this) dashboard.
Please create the preview site, please provide a sample business, and please fix the broken Cypress test(s). |
@@ -10,6 +10,7 @@ interface MenuActionItem extends DropdownItem { | |||
|
|||
const filings = useBcrosFilings() | |||
const business = useBcrosBusiness() | |||
const { getStoredFlag } = useBcrosLaunchdarkly() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering about your implementation of the LD client so I looked at your code. Why don't you have streaming enabled? That would get you real-time flag updates, I think...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how that works, but I like the idea, will look into it when I get time for it. Thanks !
/gcbrun |
testing details (staff account in dev to test) |
Can be tested in dev, as the merge does not allow preview anymore :/ https://business-dashboard-dev.web.app/C9900819?accountid=3040 |
Hey, did you notice this? FYI: |
This should also display an alert. Compare with https://dev.business.bcregistry.gov.bc.ca/C9900819?accountid=3040. Please create a new ticket if needed. |
*Issue:24464 *bcgov/entity#24464
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).