Fix for non staff user view/change business info modal #84
Conversation
BrandonSharratt
requested review from
hfekete,
severinbeauvais and
patrickpeinanw
|
Could you please trigger the preview site build and/or provide before and after screenshots to show what this change did? Thanks. |
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-84-j8v0hdv5.web.app SB says, try this: https://business-dashboard-dev--pr-84-j8v0hdv5.web.app/BC0871288 |
|
My test results... AlterationAs a regular user
As staffI am redirected to Edit UI to perform the alteration. This is consistent with Filings UI. Voluntary DissolutionAs a regular userThis is not consistent with Filings UI, which shows you the action in the More Actions dropdown, and then a dialog when you select it.
As staff
|
BrandonSharratt
changed the title
|
This PR is not addressing visibility or enabled state of actions. However, in the case demonstrated it should be disabled. The business is not in good standing, so it does not show in the allowable actions for this business which is considered a blocker in the legal api. |
| @@ -63,7 +63,7 @@ const setShowDissolutionDialog = (show: boolean) => { | |||
| } | |||
|
|
|||
| const dialogTitle = computed<string>(() => { | |||
| return (!currentBusiness?.value?.goodStanding && hasRoleStaff) | |||
| return showChangeNotInGoodStandingDialog.value | |||
There was a problem hiding this comment.
I don't understand how a variable for whether to show a dialog can be used to select one other other string (or template, below).
I cannot verify this as I cannot get to the dissolution version of this dialog.
So... the dissolution version of this dialog will NEVER show? |
No it'll show you just need a business in good standing |
|
Here is example of Voluntary dissolution dialog from the PR.
Lets close this PR if it fixes what the ticket asks for, and lets create new verify or bug ticket if we are having some issues in a flow. |
|
ticket to verify dissolve flow for not in good standing business: |
Is there still a "Business is not in good standing -- voluntary dissolution" dialog? How do I get to it? |
*Issue:*bcgov/entity#24459
Description of changes:
Fix the text that shows for non staff user.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).