24389, 22238 - allowable actions logic; some other updates to allowed actions #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issues with non disabled buttons.
hfekete
requested review from
patrickpeinanw,
BrandonSharratt and
severinbeauvais
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-79-si5h6n2c.web.app |
BrandonSharratt
approved these changes
Nov 26, 2024
| }) | ||
|
|
||
| async function fetchVisibleActions (businessType: string, businessStatus: string) { | ||
| interface CouldFileI { |
There was a problem hiding this comment.
Likely should be in it's own file
severinbeauvais
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
LGTM but please fix conflict before merging.
Also, I recommend updating the app version (in package.json) so that you can tell what version is deployed in different environments, and can therefore deduce whether your changes should be there or not. cc: @BrandonSharratt
hfekete
added a commit
to hfekete/business-dashboard-ui
that referenced
this pull request
Nov 27, 2024
hfekete
added a commit
to hfekete/business-dashboard-ui
that referenced
this pull request
Nov 27, 2024
hfekete
added a commit
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:24389 bcgov/entity#24389
Issue:22238 bcgov/entity#22238
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).