Fix styling for filing history items #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfekete
approved these changes
Nov 25, 2024
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-77-opu1ygfd.web.app SB says, try this: https://business-dashboard-dev--pr-77-opu1ygfd.web.app/BC0883569 |
patrickpeinanw
force-pushed
the
development
branch
from
8b75411 to
4dace97
Compare
|
@severinbeauvais here are some examples you can use Todo Section:
Pending Section:
Filing History:
I've also created new ticket to update the breadcrumb links so they can be opened in a new tab and a new window |
patrickpeinanw
commented
Nov 26, 2024
Comment on lines
+284
to
+287
| "directorChange": { | ||
| "title": "File Director Change", | ||
| "draftTitle": "Director Change" | ||
| }, |
There was a problem hiding this comment.
Caught this bug and got it fixed. The i18n path for director change was missing so the todo item title was not rendered properly.
Before:
Now:
severinbeauvais
approved these changes
Nov 26, 2024
patrickpeinanw
force-pushed
the
development
branch
2 times, most recently
from
1648cd7 to
a722a4b
Compare
patrickpeinanw
force-pushed
the
development
branch
from
a722a4b to
152a85d
Compare
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-77-opu1ygfd.web.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue:*bcgov/entity#24391
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).