24289 - style: fix flexgrid to wrap on small sized screens and smaller #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfekete
requested review from
patrickpeinanw and
BrandonSharratt
and removed request for
patrickpeinanw
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-71-6sv5hfgs.web.app |
patrickpeinanw
approved these changes
Nov 20, 2024
| <div class="flex pt-5 text-bcGovGray-900 app-inner-container"> | ||
| <div class="grow" data-cy="business-details-name"> | ||
| <div | ||
| id="bcros-business-details" |
There was a problem hiding this comment.
In the temp url, there are some extra space at the top of the tombstone. I guess it is caused by this 'pt-7'.
| <div | ||
| id="bcros-main-header__container" | ||
| class="flex flex-wrap content-center h-[68px] app-inner-container" | ||
| > | ||
| <div id="bcros-main-header__container"> |
There was a problem hiding this comment.
Is there a reason for removing these classes? It seems the header lost some vertical padding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue:24289 *bcgov/entity#24289
Description of changes:
fix style for flexgrid to wrap on small sized screens and smaller
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).