Voluntary Dissolution filing display changes #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-61-qfb1xk2v.web.app |
| @@ -46,20 +39,7 @@ const dissolutionDateTime = | |||
| <div v-else-if="isStatusCompleted" data-cy="completed-dissolution-details"> | |||
| <strong>{{ $t('text.filing.dissolution.completed') }}</strong> | |||
|
|
|||
| <p v-if="isEntityFirm"> | |||
There was a problem hiding this comment.
we want to keep this v-if as different text is displayed based on whether the business is an entity firm or not. I think we get incorrect text in the screenshot because isEntityFirm is actually a function. Changing it to v-if="isEntityFirm()" can solve the issue.
There was a problem hiding this comment.
added back along with all the other stuff that was ripped out as part of removing
Comment on lines
61
to
62
|
|
||
| <p v-if="!isEntityFirm"> |
There was a problem hiding this comment.
brought back but as a v-else instead of a !
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-61-qfb1xk2v.web.app |
patrickpeinanw
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue:*bcgov/entity#23976
Description of changes:
Added spacing between the lines in filing, added the fallback case for when it's paid and effective now, removed the switch between entityFirm and !entityFirm text as it was not correct.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).