Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side accordions for addresses, directors, partners and proprietors #6

Merged
merged 7 commits into from
Jun 24, 2024

Conversation

patrickpeinanw
Copy link
Collaborator

@patrickpeinanw patrickpeinanw commented Jun 18, 2024

*Issue:*bcgov/entity#21298
*Issue:*bcgov/entity#21300

Description of changes:

  • Office Addresses Accordion
  • Business Addresses section (not accordion) for Sole Proprietorship and General Partnership
  • Current Directors Accordion
  • Partners Accordion
  • Proprietors Accordion

Use these businesses to access different views:

  • BC0871427
  • FM1060270
  • FM1060265

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@patrickpeinanw patrickpeinanw self-assigned this Jun 18, 2024
@patrickpeinanw
Copy link
Collaborator Author

/gcbrun

@bcgov bcgov deleted a comment from bcregistry-sre Jun 18, 2024
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-6-7joh8chs.web.app

Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey nice work! Looks good to me, I've just got one minor comment and can you please add some tests (a cypress test securing the address on the dahsboard and 1 basic vitest for the AddressAccordian would be good)

package.json Outdated Show resolved Hide resolved
@patrickpeinanw
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-6-7joh8chs.web.app

@patrickpeinanw patrickpeinanw changed the title office addresses component and basic dashboard template Side accordions for addresses, directors, partners and proprietors Jun 21, 2024
@kialj876 kialj876 merged commit 7475402 into bcgov:main Jun 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants