Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - staff filing options #50

Merged
merged 12 commits into from
Oct 10, 2024
Merged

UI - staff filing options #50

merged 12 commits into from
Oct 10, 2024

Conversation

patrickpeinanw
Copy link
Collaborator

*Issue:*bcgov/entity#21787

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@patrickpeinanw patrickpeinanw self-assigned this Oct 9, 2024
@patrickpeinanw
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-50-33ig9t6x.web.app

@patrickpeinanw patrickpeinanw marked this pull request as ready for review October 9, 2024 19:31
@patrickpeinanw
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-50-33ig9t6x.web.app

Copy link
Collaborator

@hfekete hfekete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good!
Did a quick scan and could not find any issues.

@hfekete
Copy link
Collaborator

hfekete commented Oct 9, 2024

Just before merging in, make sure tests are passing

@patrickpeinanw
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-50-33ig9t6x.web.app

@patrickpeinanw
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-50-33ig9t6x.web.app

@patrickpeinanw patrickpeinanw merged commit 30712a4 into bcgov:main Oct 10, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants