Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21297 - Business Tombstone updates #11

Merged
merged 22 commits into from
Jul 5, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adding cypress tests.
hfekete committed Jul 4, 2024
commit 0c22ad9e79f8603ed32b234b2275efd0e283961e
48 changes: 46 additions & 2 deletions cypress/e2e/components/tombstone/statuses.cy.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,59 @@
context('Business tombstone', () => {
it('Statuses verification, active, BC limited', () => {
cy.visitBusinessDash('BC0871427', 'BEN')
cy.visitBusinessDashFor('businessInfo/ben/active.json')
// badges
cy.get('[data-cy="badge.historical"]').should('not.exist')
// links
cy.get('[data-cy="button.colinLink"]').should('not.exist')
cy.get('[data-cy="button.viewAndChangeBusinessInfo"]').should('exist')
cy.get('[data-cy="button.downloadSummary"]').should('exist')
cy.get('[data-cy="button.moreActions"]').should('exist')

cy.visitBusinessDash('BC0814603', 'BEN', true)
cy.visitBusinessDashFor('businessInfo/bc/historical.json')
// badges
cy.get('[data-cy="badge.historical"]').should('exist')
// links
cy.get('[data-cy="button.colinLink"]').should('not.exist')
cy.get('[data-cy="button.viewAndChangeBusinessInfo"]').should('not.exist')
cy.get('[data-cy="button.downloadSummary"]').should('exist')
cy.get('[data-cy="button.moreActions"]').should('not.exist')

cy.visitBusinessDashFor('businessInfo/ben/active-frozen-not_in_good_standing.json')
// badges
cy.get('[data-cy="badge.historical"]').should('not.exist')
// links
cy.get('[data-cy="button.colinLink"]').should('not.exist')
cy.get('[data-cy="button.viewAndChangeBusinessInfo"]').should('exist')
cy.get('[data-cy="button.downloadSummary"]').should('exist')
cy.get('[data-cy="button.moreActions"]').should('exist')


Check failure on line 30 in cypress/e2e/components/tombstone/statuses.cy.ts

GitHub Actions / linting (20)

More than 1 blank line not allowed
cy.visitBusinessDashFor('businessInfo/cp/active.json')
// badges
cy.get('[data-cy="badge.historical"]').should('not.exist')
// links
cy.get('[data-cy="button.colinLink"]').should('not.exist')
cy.get('[data-cy="button.viewAndChangeBusinessInfo"]').should('exist')
cy.get('[data-cy="button.downloadSummary"]').should('exist')
cy.get('[data-cy="button.moreActions"]').should('exist')

cy.visitBusinessDashFor('businessInfo/gp/active.json')
// badges
cy.get('[data-cy="badge.historical"]').should('not.exist')
// links
cy.get('[data-cy="button.colinLink"]').should('not.exist')
cy.get('[data-cy="button.viewAndChangeBusinessInfo"]').should('exist')
cy.get('[data-cy="button.downloadSummary"]').should('exist')
cy.get('[data-cy="button.moreActions"]').should('exist')

cy.visitBusinessDashFor('businessInfo/sp/active.json')
// badges
cy.get('[data-cy="badge.historical"]').should('not.exist')
// links
cy.get('[data-cy="button.colinLink"]').should('not.exist')
cy.get('[data-cy="button.viewAndChangeBusinessInfo"]').should('exist')
cy.get('[data-cy="button.downloadSummary"]').should('exist')
cy.get('[data-cy="button.moreActions"]').should('exist')

Check failure on line 56 in cypress/e2e/components/tombstone/statuses.cy.ts

GitHub Actions / linting (20)

Block must not be padded by blank lines

})
})
44 changes: 44 additions & 0 deletions cypress/fixtures/businessInfo/bc/historical.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
{
"business": {
"adminFreeze": false,
"allowedActions": {
"digitalBusinessCard": false,
"filing": {
"filingSubmissionLink": "https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/BC0814603/filings",
"filingTypes": []
}
},
"alternateNames": [],
"arMaxDate": "2012-03-25",
"arMinDate": "2012-01-25",
"associationType": null,
"complianceWarnings": [],
"dissolutionDate": "2023-04-23",
"fiscalYearEndDate": "2023-02-17",
"foundingDate": "2008-01-25T01:40:11+00:00",
"goodStanding": true,
"hasCorrections": false,
"hasCourtOrders": false,
"hasRestrictions": false,
"identifier": "BC0814603",
"inDissolution": false,
"lastAddressChangeDate": "2008-01-24",
"lastAnnualGeneralMeetingDate": "",
"lastAnnualReportDate": "2011-01-25",
"lastDirectorChangeDate": "2008-01-24",
"lastLedgerTimestamp": "2023-02-17T21:51:48.441158+00:00",
"lastModified": "2023-04-24T05:55:43.070862+00:00",
"legalName": "CLIMATE LAW CORPORATION - IMPORT_TEST",
"legalType": "BC",
"naicsCode": null,
"naicsDescription": null,
"naicsKey": null,
"nextAnnualReport": "2012-01-25T08:00:00+00:00",
"noDissolution": false,
"state": "HISTORICAL",
"stateFiling": "https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/businesses/BC0814603/filings/144622",
"submitter": "Registry Staff",
"taxId": "123",
"warnings": []
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
{
"business": {
"adminFreeze": true,
"allowedActions": {
"digitalBusinessCard": false,
"filing": {
"filingSubmissionLink": "https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/BC0871330/filings",
"filingTypes": [
{
"displayName": "Transition Application",
"feeCode": "TRANS",
"name": "transition"
}
]
}
},
"alternateNames": [
{
"name": "KIALS BUSINESS TRANSLATION",
"startDate": "2023-03-20",
"type": "TRANSLATION"
},
{
"name": "NAME",
"startDate": "2023-03-28",
"type": "TRANSLATION"
}
],
"arMaxDate": "2024-05-05",
"arMinDate": "2024-03-06",
"associationType": null,
"complianceWarnings": [],
"fiscalYearEndDate": "2023-03-06",
"foundingDate": "2023-03-06T20:04:56.893589+00:00",
"goodStanding": false,
"hasCorrections": false,
"hasCourtOrders": false,
"hasRestrictions": false,
"identifier": "BC0871330",
"inDissolution": false,
"lastAddressChangeDate": "2023-03-06",
"lastAnnualGeneralMeetingDate": "",
"lastAnnualReportDate": "",
"lastDirectorChangeDate": "2023-03-20",
"lastLedgerTimestamp": "2023-03-06T20:05:00.362771+00:00",
"lastModified": "2024-06-27T21:32:03.087298+00:00",
"legalName": "KIALS BUSINESS NAME CORP.",
"legalType": "BEN",
"naicsCode": null,
"naicsDescription": null,
"naicsKey": null,
"nextAnnualReport": "2024-03-06T08:00:00+00:00",
"noDissolution": false,
"state": "ACTIVE",
"submitter": "Registry Staff",
"warnings": []
}
}
106 changes: 106 additions & 0 deletions cypress/fixtures/businessInfo/ben/active.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
{
"business": {
"adminFreeze": false,
"allowedActions": {
"digitalBusinessCard": false,
"filing": {
"filingSubmissionLink": "https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/BC0871427/filings",
"filingTypes": [
{
"displayName": "Request for AGM Extension",
"feeCode": "AGMDT",
"name": "agmExtension"
},
{
"displayName": "AGM Location Change",
"feeCode": "AGMLC",
"name": "agmLocationChange"
},
{
"displayName": "Alteration",
"feeCode": "ALTER",
"name": "alteration"
},
{
"displayName": "Amalgamation Application (Regular)",
"feeCode": "AMALR",
"name": "amalgamationApplication",
"type": "regular"
},
{
"displayName": "Amalgamation Application Short-form (Vertical)",
"feeCode": "AMALV",
"name": "amalgamationApplication",
"type": "vertical"
},
{
"displayName": "Amalgamation Application Short-form (Horizontal)",
"feeCode": "AMALH",
"name": "amalgamationApplication",
"type": "horizontal"
},
{
"displayName": "Annual Report",
"feeCode": "BCANN",
"name": "annualReport"
},
{
"displayName": "Address Change",
"feeCode": "BCADD",
"name": "changeOfAddress"
},
{
"displayName": "Director Change",
"feeCode": "BCCDR",
"name": "changeOfDirectors"
},
{
"displayName": "6-Month Consent to Continue Out",
"feeCode": "CONTO",
"name": "consentContinuationOut"
},
{
"displayName": "Voluntary Dissolution",
"feeCode": "DIS_VOL",
"name": "dissolution",
"type": "voluntary"
},
{
"displayName": "Transition Application",
"feeCode": "TRANS",
"name": "transition"
}
]
}
},
"alternateNames": [],
"arMaxDate": "2024-06-28",
"arMinDate": "2024-06-27",
"associationType": null,
"complianceWarnings": [],
"fiscalYearEndDate": "2023-06-27",
"foundingDate": "2023-06-27T21:48:45.599278+00:00",
"goodStanding": true,
"hasCorrections": false,
"hasCourtOrders": false,
"hasRestrictions": false,
"identifier": "BC0871427",
"inDissolution": false,
"lastAddressChangeDate": "2023-06-27",
"lastAnnualGeneralMeetingDate": "",
"lastAnnualReportDate": "",
"lastDirectorChangeDate": "2024-05-22",
"lastLedgerTimestamp": "2023-06-27T21:48:47.354364+00:00",
"lastModified": "2024-05-22T16:22:39.006738+00:00",
"legalName": "0871427 B.C. LTD.",
"legalType": "BEN",
"naicsCode": null,
"naicsDescription": null,
"naicsKey": null,
"nextAnnualReport": "2024-06-27T07:00:00+00:00",
"noDissolution": false,
"state": "ACTIVE",
"submitter": "bcsc/jocxgslo54oopxozrht4uuneaxzhubek",
"warnings": []
}
}
68 changes: 68 additions & 0 deletions cypress/fixtures/businessInfo/cp/active.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
{
"business": {
"adminFreeze": false,
"allowedActions": {
"digitalBusinessCard": false,
"filing": {
"filingSubmissionLink": "https://legal-api-dev.apps.silver.devops.gov.bc.ca/api/v2/CP1002605/filings",
"filingTypes": [
{
"displayName": "Annual Report",
"feeCode": "OTANN",
"name": "annualReport"
},
{
"displayName": "Address Change",
"feeCode": "OTADD",
"name": "changeOfAddress"
},
{
"displayName": "Director Change",
"feeCode": "OTCDR",
"name": "changeOfDirectors"
},
{
"displayName": "Voluntary Dissolution",
"feeCode": "DIS_VOL",
"name": "dissolution",
"type": "voluntary"
},
{
"displayName": "Special Resolution",
"feeCode": "SPRLN",
"name": "specialResolution"
}
]
}
},
"alternateNames": [],
"arMaxDate": "2024-06-28",
"arMinDate": "2024-01-01",
"associationType": "CP",
"complianceWarnings": [],
"fiscalYearEndDate": "2023-11-29",
"foundingDate": "2023-11-29T00:11:46.078781+00:00",
"goodStanding": true,
"hasCorrections": false,
"hasCourtOrders": false,
"hasRestrictions": false,
"identifier": "CP1002605",
"inDissolution": false,
"lastAddressChangeDate": "2024-06-28",
"lastAnnualGeneralMeetingDate": "",
"lastAnnualReportDate": "",
"lastDirectorChangeDate": "2024-02-02",
"lastLedgerTimestamp": "2023-11-29T00:11:52.653760+00:00",
"lastModified": "2024-06-28T16:36:37.363380+00:00",
"legalName": "BTR'S COOP",
"legalType": "CP",
"naicsCode": null,
"naicsDescription": null,
"naicsKey": null,
"nextAnnualReport": "2024-11-29T08:00:00+00:00",
"noDissolution": false,
"state": "ACTIVE",
"submitter": "bcsc/zgcbnhm6u7fprxi7ajt6kff7gsky43ta",
"warnings": []
}
}
Loading

Unchanged files with check annotations Beta

<div class="flex flex-row gap-1.5 text-sm">
<template v-if="!!currentBusiness.identifier">
<div v-if="currentBusiness.state === BusinessStateE.HISTORICAL" class="flex flex-row gap-1.5">
<BcrosChips :label="$t('label.business.status.historical')" data-cy="badge.historical" />

Check warning on line 5 in src/components/bcros/businessDetails/Status.vue

GitHub Actions / linting (20)

Multiple spaces found before '/>'
<span>{{ getReasonText }}</span>
</div>
<div v-if="currentBusiness.state === BusinessStateE.ACTIVE && isInLimitedRestoration">