Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24819 - fix redirection for voluntary dissolution draft #106

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

patrickpeinanw
Copy link
Collaborator

@patrickpeinanw patrickpeinanw commented Dec 9, 2024

*Issue:*bcgov/entity#24819

Description of changes:
Add business identifier to the url path so the redirection is working.
See this example: https://business-dashboard-dev--pr-106-7f2yso96.web.app/BC0883735 (accessed by IDIR)
Click the "Resume" button and get to the voluntary dissolution filing page.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@patrickpeinanw patrickpeinanw self-assigned this Dec 9, 2024
@patrickpeinanw
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-106-7f2yso96.web.app

@patrickpeinanw patrickpeinanw marked this pull request as ready for review December 9, 2024 23:03
Copy link
Collaborator

@BrandonSharratt BrandonSharratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming the bootstrap case isn't an issue

@patrickpeinanw patrickpeinanw merged commit 9e1955d into bcgov:main Dec 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants