Version downloading/deleting #84
Conversation
Coverage Report (Application)
|
Coverage Report (Frontend)
|
kamorel
force-pushed
the
feature/version-actions
branch
from
8c37a97 to
c1ae264
Compare
kamorel
force-pushed
the
feature/version-actions
branch
from
e6bc0fe to
912c120
Compare
kamorel
force-pushed
the
feature/version-actions
branch
from
912c120 to
e08f32e
Compare
kamorel
force-pushed
the
feature/version-actions
branch
from
e08f32e to
b616c2e
Compare
| toast.success('File deleted'); | ||
| await versionStore.fetchVersions({ objectId: props.objectId }); |
There was a problem hiding this comment.
i think i found when deleting any version except latest, that version remains in the table until you do a hard refresh.
maybe the fetchVersions() needs to do that partition logic somewhere to remove that old version from the store (?)
There was a problem hiding this comment.
or maybe it's because the route isnt changing 🤔
| style="display: none" | ||
| accept="*" | ||
| @change="onChange" | ||
| /> |
There was a problem hiding this comment.
FYI. Sharolyn mentioned that a 'uploading progress indicator' would be good.
i would have thought it would be ok to tackle that later, along with showing a something similar in the main upload panel. realistically people aren't going to be updating big files anytime soon.
... if we did want to do something short term.. there might be a a quick win if we could put in something here like:
<Spinner v-if"!done" /> (using a flag in the onUpload() function)
| @@ -142,24 +146,28 @@ watch( [props], () => { | |||
| v-if="data.public || permissionStore.isObjectActionAllowed( | |||
There was a problem hiding this comment.
just a thought..i think they can't even get to the file details page if they havent got READ permission. but if we re-use this component, then this is good.
| </Column> | ||
| </DataTable> | ||
| </div> | ||
| <GridRow |
There was a problem hiding this comment.
i think this is good.. not sure datatable was neccessary
kamorel
force-pushed
the
feature/version-actions
branch
from
3af2d07 to
397a0ff
Compare
Description
Allows specific object versions to be downloaded and deleted.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments