-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement loading icon or hover effect #82
Conversation
52c44a3
to
1142b7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed using https://bcbox-dev-pr-82.apps.silver.devops.gov.bc.ca/ as provided by Dragan.
Hover appears good, a spot test around various actions seem appropriately subtle as a slight difference in lightness/darkness, agree with the dev choice to lighten darker elements on hover.
Loading animation of table appears to be red circle. Red usually indicates failure and is not a prominent colour in our scheme, not sure if this is an error or intentional but loading should be a shade of blue or grey for consistency. Table also briefly loads with large dark grey dectangle, would prefer a subtle loading colour more congruent with the design such as a white.
Attaching image I was able to capture of red spinner, it's tough to get because it's so quick so you only see part of it.
As requested, overwriting spinner colour to grey and loading overlay to white. |
81ace0e
to
838bda3
Compare
838bda3
to
aa5d921
Compare
Description
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3167
Hover effect: css has been used as the last tool, as font-awesome-icons do not support hover animation.
Loading icon: primevue spinner has been used for Bucket and Object tables.
Fix after Tyler's comment:
Types of changes
Checklist
Further comments