-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review all toast notifications #81
Conversation
…itle and msg format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general styling and consistency fixes needed. There are some jarring presentation/wording quirks with present-progressive and a past participle statements in one toast. Some of these messages suffice just being one liner alerts instead of being verbose toasts with a title and body. Would recommend consulting with Tyler on this if this hasn't been raised yet and how to simplify messaging so that it remains concise, but also consistent with the rest of the other alert styles.
3d02334
to
e1bdc5e
Compare
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-2960
New common functions have been added to 'useToast.ts' - success, error and info. These three new functions contain a new (appropriate) title format (e.g. verb-ing object 'Configuring object'), and message defined by our UI/UX designer. Also, timeouts are being read from the constant file.
SUCCESS:
ERROR:
INFO:
Description
Types of changes
Checklist
Further comments