Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Helm chart to allow optional notification banner #75

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix Helm chart to allow optional notification banner #75

merged 1 commit into from
Apr 26, 2023

Conversation

jujaga
Copy link
Member

@jujaga jujaga commented Apr 26, 2023

Description

Allow FRONTEND_NOTIFICATION_BANNER to be optionally declared in configmap

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jujaga jujaga added the bug Something isn't working label Apr 26, 2023
@jujaga jujaga self-assigned this Apr 26, 2023
@github-actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 75% ( 51 / 68 )
Methods: 62.5% ( 5 / 8 )
Lines: 82.61% ( 38 / 46 )
Branches: 57.14% ( 8 / 14 )

@github-actions
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 39.48% ( 334 / 846 )
Methods: 35.2% ( 69 / 196 )
Lines: 46.63% ( 242 / 519 )
Branches: 17.56% ( 23 / 131 )

@kamorel kamorel merged commit f7bfa76 into master Apr 26, 2023
@kamorel kamorel deleted the bugfix/configmap branch April 26, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcgv123 bcgv123 bcgv123 approved these changes

@TimCsaky TimCsaky TimCsaky approved these changes

@kamorel kamorel kamorel approved these changes

Assignees

@jujaga jujaga

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jujaga @kamorel @TimCsaky @bcgv123