Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice on Configure Bucket form #72

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Add notice on Configure Bucket form #72

merged 1 commit into from
Apr 13, 2023

Conversation

TimCsaky
Copy link
Contributor

Advise bucket creators to contact IDIM team regarding BCeID users

ticket 2943: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-2943:
"Update the Bucket configure modal to articulate Disclaimer for bucket admins wanting to share with BCeID users must be added to tell them they must consult with IDIM prior to offering sharing to BCeID users"

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@TimCsaky TimCsaky requested a review from tpantella April 13, 2023 19:24
@github-actions
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 6.71% ( 56 / 834 )
Methods: 0.52% ( 1 / 194 )
Lines: 9.53% ( 49 / 514 )
Branches: 4.76% ( 6 / 126 )

@github-actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 75% ( 51 / 68 )
Methods: 62.5% ( 5 / 8 )
Lines: 82.61% ( 38 / 46 )
Branches: 57.14% ( 8 / 14 )

Advise bucket creators to contact IDIM team regarding
BCeID users
@jujaga jujaga merged commit bb4f5a7 into master Apr 13, 2023
@jujaga jujaga deleted the idim-notice branch April 13, 2023 20:10
Copy link

@tpantella tpantella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants