Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check bucket exists before create/update #66

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Conversation

kamorel
Copy link
Contributor

@kamorel kamorel commented Apr 5, 2023

Description

Creates a form differential so COMS only receives the modified bucket information for updates.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Coverage Report (Frontend)

Totals Coverage
Statements: 6.79% ( 57 / 839 )
Methods: 0.51% ( 1 / 195 )
Lines: 9.69% ( 50 / 516 )
Branches: 4.69% ( 6 / 128 )

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Coverage Report (Application)

Totals Coverage
Statements: 75% ( 51 / 68 )
Methods: 62.5% ( 5 / 8 )
Lines: 82.61% ( 38 / 46 )
Branches: 57.14% ( 8 / 14 )

frontend/src/utils/utils.ts Outdated Show resolved Hide resolved
@kamorel kamorel force-pushed the feature/bucket-check branch from 5160e20 to 6bfdb08 Compare April 5, 2023 20:38
@jujaga jujaga merged commit 2b2f8da into master Apr 5, 2023
@jujaga jujaga deleted the feature/bucket-check branch April 5, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants