Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: File search, object refresh #62

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Conversation

loneil
Copy link
Contributor

@loneil loneil commented Mar 27, 2023

Description

Implementation of (in-memory, primevue table) file search. Use primevue filter from https://primevue.org/datatable/#filter
(note there's a current Typescript bug that they keep trying to fix without success, see comment in code)

case-insensitive 'contains' string search using name column only. This could be expanded to other columns if desired
image

Handles the truncation alright as well
image

Not sure if this is the exact UX/placement for this, could adjust but looks fine to me. Maybe check with Tyler.
Could remove darker background and/or borders

Also add object list refresh button while we're at it next to search.

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 75% ( 51 / 68 )
Methods: 62.5% ( 5 / 8 )
Lines: 82.61% ( 38 / 46 )
Branches: 57.14% ( 8 / 14 )

@github-actions
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 5.64% ( 44 / 780 )
Methods: 0% ( 0 / 181 )
Lines: 8.73% ( 42 / 481 )
Branches: 1.69% ( 2 / 118 )

Copy link
Member

@jujaga jujaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks functional at semantic and visual inspection level. Let's put in some // TODO notes in code so we remember to revisit when we update primevue dependency as well as re-wrap the new component in our lib.

frontend/src/components/object/ObjectTable.vue Outdated Show resolved Hide resolved
Signed-off-by: Lucas ONeil <[email protected]>
@loneil loneil force-pushed the feature/objectTableSearch branch from 40ed264 to ea8c415 Compare March 29, 2023 18:22
Signed-off-by: Lucas ONeil <[email protected]>
@jujaga jujaga merged commit 37e5015 into master Mar 29, 2023
@jujaga jujaga deleted the feature/objectTableSearch branch March 29, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants