Styling adjustments #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loneil
requested review from
jujaga,
kamorel,
TimCsaky and
bcgv123
as code owners
Coverage Report (Application)
|
Coverage Report (Frontend)
|
loneil
force-pushed
the
feature/uiQaFixes
branch
3 times, most recently
from
b62767e to
ac07826
Compare
loneil
force-pushed
the
feature/uiQaFixes
branch
2 times, most recently
from
ff82cc5 to
3594376
Compare
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
loneil
force-pushed
the
feature/uiQaFixes
branch
from
3594376 to
0f605bc
Compare
Signed-off-by: Lucas ONeil <[email protected]>
loneil
force-pushed
the
feature/uiQaFixes
branch
from
0f605bc to
744a7f7
Compare
loneil
commented
Mar 24, 2023
Comment on lines
+62
to
+64
| // Primary color overrides for buttons and action items (checkboxes etc) | ||
| // Note this could be eventually replaced by a custom themeing (which has JUST been introduced in Primevue) | ||
| // once it is more settled implementation-wise |
There was a problem hiding this comment.
Wouldn't adopt the PrimeVue open-source theme customization yet, just came out and has all these notes about changes. This is easy enough at this point
Signed-off-by: Lucas ONeil <[email protected]>
Signed-off-by: Lucas ONeil <[email protected]>
bcgv123
approved these changes
Mar 24, 2023
jujaga
approved these changes
Mar 24, 2023
Signed-off-by: Lucas ONeil <[email protected]>
kamorel
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Styling items from https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3050
More to come in another PR later on, grouping these ones together.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments