Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/3098 small bugs in test #51

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Fix/3098 small bugs in test #51

merged 7 commits into from
Mar 15, 2023

Conversation

bcgv123
Copy link
Contributor

@bcgv123 bcgv123 commented Mar 15, 2023

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@bcgv123 bcgv123 force-pushed the fix/3098-small-bugs-in-test branch from ec876c4 to 7f06bb9 Compare March 15, 2023 21:37
@github-actions
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 75% ( 51 / 68 )
Methods: 62.5% ( 5 / 8 )
Lines: 82.61% ( 38 / 46 )
Branches: 57.14% ( 8 / 14 )

@github-actions
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 5.38% ( 42 / 781 )
Methods: 0% ( 0 / 181 )
Lines: 8.3% ( 40 / 482 )
Branches: 1.69% ( 2 / 118 )

Copy link
Contributor

@TimCsaky TimCsaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to resolve a conflict

Copy link
Member

@jujaga jujaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check import ordering. While the groupings are correct, you also want to do a secondary sort based on the from string value.

frontend/src/components/bucket/BucketSidebar.vue Outdated Show resolved Hide resolved
Comment on lines 5 to 7
import { Permissions } from '@/utils/constants';
import { Button } from '@/lib/primevue';
import { usePermissionStore, useUserStore } from '@/store';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@/lib
@/store
@/utils

@@ -1,7 +1,12 @@
<script setup lang="ts">
import { storeToRefs } from 'pinia';
import { onBeforeMount, ref, Ref, watch } from 'vue';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref is actually a type
import type { Ref } from 'vue';

Copy link
Contributor

@TimCsaky TimCsaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all working for me now

@jujaga jujaga merged commit d29927a into master Mar 15, 2023
@jujaga jujaga deleted the fix/3098-small-bugs-in-test branch March 15, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants